refactoring proposals

[VectorBCO]

1 "string " + $var should be replaced with "string $var" in all places
2 similar code should be replaced with functions
3 if ($result){return $result} doing exact the same as return $result

[criffo]

Hi
Gets memberof attribute recurisvely for an active directory object (computer,user,group)

LDAP request via .Net classes, namespace System.DirectoryServices for the directory searcher and active dorectory classes, no need to import activedirectory module
Allows to include the domain users or computers membership as well
It takes by default the forest level but the search can be restricted to domain scope or extended to domain and its trusts, forest and its trusts or explicit domains
it returns void in case of no result, and in case of result, a list of object with string attributes for csv export.

[VectorBCO]

great, huge work, but hard to read
thanks for sharing, if i will have a time will try create pull request with some refactoring
have a good day
vd

[criffo]

sorry lol I saw no description.
I ve just read your 5 comments
for the 3rd it s true I can adjust and return a list with no item.
for the second atually it s a function, I wanted to make it general regaindg all use case we could do of it

[VectorBCO]

i saw that this is a function, but u have huge if blocks and else blocks which looks similar, so this is a good place replace copy/paste code with a function
that function could be defined inside your original one for limiting scope and internal functions visibility

[criffo]

Thanks for your message, I recognised it s not easy to read, I tried to comment to make my idea clear but it s quite big
Thank you :)

[criffo]

indeed the begning, I test the scope and if I can talk to targeted domains
I found it easier to understand with a switch than if and else for a better understanding but it is the basis of the execution