From 8db161ad837a4f484b97f0a6c7b69ffcf106650a Mon Sep 17 00:00:00 2001 From: Luiz Ferraz Date: Thu, 5 Dec 2024 18:50:51 -0300 Subject: [PATCH] Fix incorrect timeout log on `evaluate` requests (#442) --- src/evaluator.ts | 2 +- test/evaluator.test.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/evaluator.ts b/src/evaluator.ts index c54ee8b3..7f531161 100644 --- a/src/evaluator.ts +++ b/src/evaluator.ts @@ -170,7 +170,7 @@ export class Evaluator { let timer: number | NodeJS.Timeout | undefined; if (timeout !== undefined) { - setTimeout( + timer = setTimeout( () => { const response: ErrorResponse = { title: `Evaluation could not be completed in time for query "${reference}".`, diff --git a/test/evaluator.test.ts b/test/evaluator.test.ts index df2d3e65..f3acb15c 100644 --- a/test/evaluator.test.ts +++ b/test/evaluator.test.ts @@ -351,6 +351,8 @@ describe('An evaluator', () => { await expect(evaluator.evaluate(query, {timeout: 10})).resolves.toBe('Carol'); + jest.advanceTimersByTime(11); + expect(logger.error).not.toHaveBeenCalled(); });