limit the number of artifacts directories retained on disk

[d-honeybadger]

Description of your changes

Fixes #311

This prevents too much data from accumulating on disk, especially now that retries are happening since each retry creates an artifacts directory.

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable to ensure this PR is ready for review.
• Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

1. Create an ansiblerun - a failing one is best cause it'll be retried without one having to change the spec
2. exec into the provider-ansible pod, navigate to ansibleDir/$UID-of-the-run/artifacts
3. watch that the number of directories never exceeds the limit (you might want to set a limit lower than default for speedy testing)

[fahedouch]

integration test is very welcome :)

[d-honeybadger]

integration test is very welcome :)

Since there's no prior art, are you thinking something like this: https://github.com/crossplane/crossplane/blob/master/test/e2e/README.md? e.g. run the provider against a kind k8s cluster and have ansible-runner actually run playbooks
Or I could add a test without kind cluster but with ansible-runner installed and running real playbooks - this would be more like a unit test but with real ansible, so I guess it'd just test the ansiblerun controller and not the entire flow of setting a flag

[fahedouch]

Thanks, overall LGTM

integration test is very welcome :)

Since there's no prior art, are you thinking something like this: https://github.com/crossplane/crossplane/blob/master/test/e2e/README.md? e.g. run the provider against a kind k8s cluster and have ansible-runner actually run playbooks Or I could add a test without kind cluster but with ansible-runner installed and running real playbooks - this would be more like a unit test but with real ansible, so I guess it'd just test the ansiblerun controller and not the entire flow of setting a flag

I think it is fine to go with unit test for the moment.

let's introduce integration test in a follow-up PR! we can be inspired from other projects such as aws provider

[d-honeybadger]

I think it is fine to go with unit test for the moment.

Added a couple unit tests. I know I mentioned in the beginning using the actual ansible-runner, but when I looked closer, there's no good way to do that without running the test in a container with a custom dockerfile: ansible-runner install requires python, and that's not something we can't just curl the binary for. Adding makefile targets and/or scripts that mess with python install on the system seemed like a bad idea, and doing a custom dockerfile and make targets to build that dockerfile seemed like an overkill too, especially since there's the plan to do e2e tests with kind.

So the tests I added are your typical unit tests using dummy commands, just checking that the runner settings and command args are set correctly.

[fahedouch]

Thanks