Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distlib for Ansible Collections from source #323

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

glennpratt
Copy link
Contributor

@glennpratt glennpratt commented Mar 21, 2024

Description of your changes

Fixes #316

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Closes crossplane-contrib#316

Signed-off-by: Glenn Pratt <gpratt@akamai.com>
@glennpratt
Copy link
Contributor Author

➜  provider-ansible git:(patch-1) make reviewable
make: *** No rule to make target 'reviewable'.  Stop.

Copy link
Collaborator

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch added this to the v0.5.1 (tentative) milestone Apr 2, 2024
@fahedouch fahedouch merged commit acaba1f into crossplane-contrib:main Apr 2, 2024
7 checks passed
@glennpratt glennpratt deleted the patch-1 branch May 6, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible collections optionally depend on distlib, but that is missing
2 participants