Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check-endpoints): update grep for providers #20

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

haarchri
Copy link
Contributor

@haarchri haarchri commented Aug 7, 2024

Description of your changes

fix check-endpoints.sh when installing providers via configurations the endpoints looks like:

kubectl -n upbound-system get endpoints --no-headers                                       
crossplane-contrib-function-auto-ready   10.244.0.7:9443    17m
crossplane-contrib-function-kcl          10.244.0.8:9443    17m
crossplane-webhooks                      10.244.0.11:9443   17m
upbound-provider-aws-s3                  10.244.0.12:9443   16m
upbound-provider-family-aws              10.244.0.13:9443   17m

this part will not produce an output kubectl -n upbound-system get endpoints --no-headers | grep '^provider-' | awk '{print $1}'

Fixes #

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri
Copy link
Contributor Author

haarchri commented Aug 7, 2024

@sergenyalcin can we backport to v0.13.0 release ? thanks

Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri LGTM!

@sergenyalcin sergenyalcin merged commit cff48e2 into crossplane:main Aug 7, 2024
6 checks passed
Copy link

github-actions bot commented Aug 7, 2024

Successfully created backport PR #21 for release-0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants