Add a sync point for scaling up provider deployments #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
approved these changes
Apr 19, 2024
sergenyalcin
force-pushed
the
add-sync-point-for-import
branch
from
ea1ba91 to
dbeca64
Compare
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
add-sync-point-for-import
branch
from
dbeca64 to
c2f5dcb
Compare
ulucinar
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. Like we did before, locally validated the PR and the make e2e succeeds. If this synchronization does not serve our purposes in the Github actions context, then maybe we can consider a synchronization on the service endpoints.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a sync point for scaling up provider deployments in import step.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Locally tested