Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handle error when sending usage metrics #3333

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

blotus
Copy link
Member

@blotus blotus commented Nov 18, 2024

Previous fix for #3295 was incomplete, better handle network failure.

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Nov 18, 2024

/kind fix

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.41%. Comparing base (9067106) to head (fae07cf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apic_metrics.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3333      +/-   ##
==========================================
- Coverage   58.41%   58.41%   -0.01%     
==========================================
  Files         351      351              
  Lines       37746    37748       +2     
==========================================
  Hits        22049    22049              
- Misses      13800    13802       +2     
  Partials     1897     1897              
Flag Coverage Δ
bats 41.21% <0.00%> (+0.07%) ⬆️
unit-linux 34.39% <0.00%> (-0.01%) ⬇️
unit-windows 29.67% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit c57dadc into master Nov 18, 2024
17 checks passed
@blotus blotus deleted the usage-metrics-crash branch November 18, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants