-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crowdsec job in daily #3481
Comments
@lacrimal: Thanks for opening an issue, it is currently awaiting triage. In the meantime, you can:
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@lacrimal: There are no 'kind' label on this issue. You need a 'kind' label to start the triage process.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Already patched for next release |
Reopen due to investigation seems this println may always print crowdsec/pkg/cwhub/download.go Line 87 in a3187d6
can we do this in the logger at debug level or info? |
If we do, then crowdsec won't be reloaded when data file are updated unless items are updated too. Does the resource have an etag or last-modified header? The above line is printed (which means a GET request is attempted) only if after a HEAD request we still can't confirm the file is up to date. It's still possible that after GET we find out the file didn't change, so no crowdsec reload is needed. But without reliable cache control on all data files I don't think there's a right thing 100% of the times Edit: you could be right that we don't need this message anymore and the needReload bool is enough, I have to check. |
imo, its okay to println for datafiles, but this is the index file so if we could ignore just the index then lgtm |
Guys,
After update I have your script in cron.daily returning this and reporting daily at 7:00.
Since your application is security tool and not virus - maybe try to be less intrusive ?
The text was updated successfully, but these errors were encountered: