Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowdsec job in daily #3481

Open
lacrimal opened this issue Feb 23, 2025 · 7 comments
Open

crowdsec job in daily #3481

lacrimal opened this issue Feb 23, 2025 · 7 comments

Comments

@lacrimal
Copy link

Guys,

After update I have your script in cron.daily returning this and reporting daily at 7:00.
Since your application is security tool and not virus - maybe try to be less intrusive ?

/etc/cron.daily/crowdsec:

Downloading /etc/crowdsec/hub/.index.json
Copy link

@lacrimal: Thanks for opening an issue, it is currently awaiting triage.

In the meantime, you can:

  1. Check Crowdsec Documentation to see if your issue can be self resolved.
  2. You can also join our Discord.
  3. Check Releases to make sure your agent is on the latest version.
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@lacrimal: There are no 'kind' label on this issue. You need a 'kind' label to start the triage process.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind bug
  • /kind packaging
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Feb 23, 2025

Already patched for next release

#3460

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Feb 24, 2025

Reopen due to investigation seems this println may always print

@mmetc

fmt.Println("Downloading " + destPath)

can we do this in the logger at debug level or info?

@mmetc
Copy link
Contributor

mmetc commented Feb 24, 2025

If we do, then crowdsec won't be reloaded when data file are updated unless items are updated too. Does the resource have an etag or last-modified header?

The above line is printed (which means a GET request is attempted) only if after a HEAD request we still can't confirm the file is up to date. It's still possible that after GET we find out the file didn't change, so no crowdsec reload is needed. But without reliable cache control on all data files I don't think there's a right thing 100% of the times

Edit: you could be right that we don't need this message anymore and the needReload bool is enough, I have to check.

@LaurenceJJones
Copy link
Contributor

imo, its okay to println for datafiles, but this is the index file so if we could ignore just the index then lgtm

@mmetc
Copy link
Contributor

mmetc commented Feb 26, 2025

#3485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants