Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-secret-env flag useless without -entrypoint #14

Open
dplummer opened this issue Jul 2, 2019 · 3 comments
Open

-secret-env flag useless without -entrypoint #14

dplummer opened this issue Jul 2, 2019 · 3 comments

Comments

@dplummer
Copy link
Contributor

dplummer commented Jul 2, 2019

Is there any reason to have -entrypoint without -secret-env? Can -secret-env be removed and rolled into -entrypoint as the default behavior?
derpityderp pushed a commit to derpityderp/daytona that referenced this issue Aug 6, 2019
- Allow token renewal increment to be user provided (cruise-automatio…
d850b55 
…n#14)

- Set the renewal threshold to a smaller value of 2 hours, instead of 12
hours. This will eliminate unnecessary and frequent renewal attempts
that occurred with the previous defaults.
- Default renewal increment value is 43200
@broamski
Copy link
Collaborator

broamski commented Oct 8, 2019

Some use cases involve running the binary in a stand alone fashion, not inside of a container, where the endpoint flag would not be used.

@dplummer
Copy link
Contributor Author

dplummer commented Oct 8, 2019

So if you run daytona -secret-env without -entrypoint it modifies the existing environment with the secrets?

@broamski
Copy link
Collaborator

broamski commented Oct 8, 2019

You're right! I think this might be a remnant from much older work that involved utilizing eval to capture outputs. Walking through this change, since it's just the removal of a boolean flag and since -entrypoint should always be also provided, this shouldn't be a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dplummer @broamski