Skip to content

Propagate headers in hmr-client-worker.ts/sendToServer #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

ch0c0l8ra1n
Copy link
Contributor

Fixes #909

crxjs vite plugins client worker currently doesn't propagate headers.

^ Request headers are lost immideately.

headers: {
'Content-Type': response.headers.get('Content-Type') ?? 'text/javascript',
},

For some reason response headers are also omitted.

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 68373eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crxjs/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vite-plugin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 4:31pm

Copy link
Contributor

github-actions bot commented Feb 5, 2025

⚠️ Important Notice: CRXJS is seeking new maintainers.

  • New issues and PRs may not receive immediate attention
  • A new maintenance team must establish itself by March 31, 2025 or this repository will be archived on June 1, 2025
  • Learn more about the transition

This is an automated message. Please do not reply to this comment.

@colearendt colearendt merged commit 5d7efa7 into crxjs:main Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will pay someone to fix this: Unable to import a .webm file
3 participants