-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Archives > All Archives > Download does not download JFR file #1738
Comments
Hang on, let me re-test this. It occurs to me that maybe the problem was my testing setup - I used the CI-built test image that should have included the correct frontend changes, but maybe that didn't work and the problem is actually the mismatch of versions. |
No, I don't think that was it - I can still reproduce the failure with a hand-built test image. |
I just tested without the frontend changes from cryostatio/cryostat-web#1127 and I am able to download both the jfr and the metadata json. I will test with the frontend changes and see if the jfr file isn't being downloaded? |
even when I run with the CI-built test image or by running |
Hmm. Make sure to try a hard-refresh in your browser as well (probably ctrl+shift+r) to make sure that your browser isn't reusing a cached version of the web-client. We have stuff in the web build process that should cachebust when the client is rebuilt but it doesn't seem to always work as intended. I'll also try to reproduce this again to verify it's real. |
Huh, trying it again now it seems to work with the CI-built image for me as well. I'll close this issue then and reopen it in case the issue reappears. |
^ @tthvo did you check out cryostatio/cryostat-web#1127 along with that build? |
Yehh I tried with the image @mwangggg sent above. |
Bah. Trying it once again now and I'm also seeing the |
Logs are not that very helpful haha
|
just tried again and I still can't reproduce this issue 😕 |
Using the same CI image as before, I just reproduced it now. Maybe let's try the exact same setup and see if we can narrow down where the differences come in.
|
@mwangggg Did u try downloading when in the |
oh my god ok I see it |
Current Behavior
Since #1692 / #1731 , attempting to download archived recording from the All Archives view partially fails - the JSON metadata file is downloaded, but the actual JFR binary is not.
Expected Behavior
Both the metadata JSON and the JFR binary should be downloaded to the local workstation filesystem.
Steps To Reproduce
rm -rf conf/h2* conf/postgres archive/* conf/metadata conf/probes.d conf/rules
main
or latestcryostat-v2.4
upstream branches,./mvnw clean package ; podman image prune -f
sh smoketest.sh
localhost:0
(Cryostat itself)localhost:0
, click the overflow menu on the recording item, and attempt to download it.jfr
and a.metadata.json
Environment
- Version: 2.4.0-snapshot, 2.5.0-snapshot
Anything else?
No response
The text was updated successfully, but these errors were encountered: