[Bug] CI startup failure

[andrewazores]

Current Behavior

Invalid workflow file: .github/workflows/push-ci.yml#L34
The workflow is not valid. .github/workflows/push-ci.yml (Line: 34, Col: 20): Invalid input, skip-itests is not defined in the referenced workflow.

Expected Behavior

CI run on push-to-main should be able to run and pass as normal.

Steps To Reproduce

No response

Environment

Since #1683

Anything else?

[andrewazores]

Run redhat-actions/podman-login@v1
Error: Error: Input required and not supplied: username

[aali309]

Run redhat-actions/podman-login@v1
Error: Error: Input required and not supplied: username

I have no clue why it is saying username not supplied when it is supplied on ci-build-image.yml file

[tthvo]

I think the argument to the line below is empty since it is a push event, not a comment event:

https://github.com/cryostatio/cryostat/blob/d33cc44ea19274b3cedddee32846250d6f881a57/.github/workflows/ci-build-image.yml#L71

[andrewazores]

Looks right. @aali309 I'm looking at that build-image step again and I'm still not sure I see why exactly the podman-login action is required. Which subsequent step in that workflow is interacting with ghcr.io? And why would it need to use a commenting user's username as the login while using the secrets.GITHUB_TOKEN as the password?

Can we try just removing the podman-login step and see if anything actually breaks?

[aali309]

yes when I remove the podman-login

workflow LINK: https://github.com/aali309/cryostat/actions/runs/6700548654/job/18206670997

on merge:

push-ci workflow LINK: https://github.com/aali309/cryostat/actions/runs/6700624381

[andrewazores]

Okay, so removing the podman-login looks OK then. Now it's failing on downloading from the GH Packages Maven repository, so there needs to be some setup with maven-settings ie. ~/.m2/settings.xml.

[aali309]

with podman login

/build_test LINK: https://github.com/aali309/cryostat/actions/runs/6700846180

retest LINK: https://github.com/aali309/cryostat/actions/runs/6700928824

Push to quay fails is expected to fail I assume because of the access restrictions (i.e username+password).
push-ci workflow LINK: https://github.com/aali309/cryostat/actions/runs/6700718429

[aali309]

Okay, so removing the podman-login looks OK then. Now it's failing on downloading from the GH Packages Maven repository, so there needs to be some setup with maven-settings ie. ~/.m2/settings.xml.

I will try this option tomorrow morning