From 9f42608cd9cefe5796bb8e099efe979a0447b459 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Tue, 29 Aug 2023 14:53:37 -0400 Subject: [PATCH 01/24] added pr-request-review.yml --- .github/workflows/pr-request-review.yml | 49 +++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 .github/workflows/pr-request-review.yml diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml new file mode 100644 index 0000000000..ca245593f9 --- /dev/null +++ b/.github/workflows/pr-request-review.yml @@ -0,0 +1,49 @@ +name: Request Review + +on: + issue_comment: + types: + - created + +jobs: + request-review: + runs-on: ubuntu-latest + steps: + - name: Check if command is '/request_review' + id: check-command + run: | + if [[ $(echo "${{ github.event.comment.body }}" | tr '[:upper:]' '[:lower:]') == "/request_review"* ]]; then + echo "::set-output name=command::true" + else + echo "::set-output name=command::false" + fi + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + - name: Add label and request review + if: steps.check-command.outputs.command == 'true' + run: | + reviewers=$(echo "${{ github.event.comment.body }}" | grep -oE "@[a-zA-Z0-9_\-]+" | grep -v "@cryostatio/reviewer(s)" | paste -sd "," -) + + echo "Adding label 'review-requested' to the PR" + gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" + + if [ -n "$reviewers" ]; then + echo "Requesting review from reviewers: $reviewers" + gh pr request-review ${{ github.event.issue.number }} --reviewer $reviewers + else + echo "Requesting review from @cryostatio/reviewer(s) team" + gh pr request-review ${{ github.event.issue.number }} --team cryostatio/reviewer(s) + fi + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + - name: Remove label on changes requested + run: | + reviews_status=$(gh pr list --json state,reviews -q ".[] | select(.number == ${{ github.event.issue.number }}) | .reviews[].state") + if [[ "$reviews_status" == *"CHANGES_REQUESTED"* ]]; then + echo "Changes requested, removing 'review-requested' label" + gh pr edit ${{ github.event.issue.number }} --remove-label "review-requested" + fi + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 7e4fc760fa7fb6dcade36660abd812e7d1212a0d Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 30 Aug 2023 11:46:11 -0400 Subject: [PATCH 02/24] fixed comments --- .github/workflows/pr-request-review.yml | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index ca245593f9..fcc87258cf 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -8,28 +8,18 @@ on: jobs: request-review: runs-on: ubuntu-latest + permissions: + pull-requests: write + if: github.repository_owner == 'cryostatio' && github.event.issue.pull_request && startsWith(github.event.comment.body, '/request_review') steps: - - name: Check if command is '/request_review' - id: check-command - run: | - if [[ $(echo "${{ github.event.comment.body }}" | tr '[:upper:]' '[:lower:]') == "/request_review"* ]]; then - echo "::set-output name=command::true" - else - echo "::set-output name=command::false" - fi - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Add label and request review - if: steps.check-command.outputs.command == 'true' run: | - reviewers=$(echo "${{ github.event.comment.body }}" | grep -oE "@[a-zA-Z0-9_\-]+" | grep -v "@cryostatio/reviewer(s)" | paste -sd "," -) + reviewers="@cryostatio/reviewers" echo "Adding label 'review-requested' to the PR" gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" if [ -n "$reviewers" ]; then - echo "Requesting review from reviewers: $reviewers" gh pr request-review ${{ github.event.issue.number }} --reviewer $reviewers else echo "Requesting review from @cryostatio/reviewer(s) team" @@ -38,10 +28,10 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Remove label on changes requested + - name: Remove label on review run: | reviews_status=$(gh pr list --json state,reviews -q ".[] | select(.number == ${{ github.event.issue.number }}) | .reviews[].state") - if [[ "$reviews_status" == *"CHANGES_REQUESTED"* ]]; then + if [[ -n "$reviews_status"]]; then echo "Changes requested, removing 'review-requested' label" gh pr edit ${{ github.event.issue.number }} --remove-label "review-requested" fi From 448269bc109d1a2c1f63e4f4e6260a234a87ad26 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 30 Aug 2023 17:07:47 -0400 Subject: [PATCH 03/24] added action/checkout --- .github/workflows/pr-request-review.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index fcc87258cf..8eca4892f1 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -12,6 +12,9 @@ jobs: pull-requests: write if: github.repository_owner == 'cryostatio' && github.event.issue.pull_request && startsWith(github.event.comment.body, '/request_review') steps: + - name: Checkout code + uses: actions/checkout@v2 + - name: Add label and request review run: | reviewers="@cryostatio/reviewers" From b0eb6cb3a8271b1890cc956b05a38a1a3e2db64d Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Thu, 31 Aug 2023 09:22:21 -0400 Subject: [PATCH 04/24] extracted removing label part --- .github/workflows/pr-request-review.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 8eca4892f1..1fb04c3ec3 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -31,12 +31,3 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Remove label on review - run: | - reviews_status=$(gh pr list --json state,reviews -q ".[] | select(.number == ${{ github.event.issue.number }}) | .reviews[].state") - if [[ -n "$reviews_status"]]; then - echo "Changes requested, removing 'review-requested' label" - gh pr edit ${{ github.event.issue.number }} --remove-label "review-requested" - fi - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From ef0b82d53f60b079f9425e73ae10f7f2283c14a5 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Thu, 31 Aug 2023 10:04:34 -0400 Subject: [PATCH 05/24] label added & extracted removing the label part --- .github/workflows/pr-request-review.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 1fb04c3ec3..b03b1b29e5 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -30,4 +30,3 @@ jobs: fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - From 7861b18f0d610481a90eff66f7c6c05479d8cb69 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Thu, 31 Aug 2023 12:43:43 -0400 Subject: [PATCH 06/24] added new workflow file for removing label part --- .../workflows/pr-remove-request-review.yml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/workflows/pr-remove-request-review.yml diff --git a/.github/workflows/pr-remove-request-review.yml b/.github/workflows/pr-remove-request-review.yml new file mode 100644 index 0000000000..22c6936ddc --- /dev/null +++ b/.github/workflows/pr-remove-request-review.yml @@ -0,0 +1,25 @@ +name: Remove Review Label + +on: + pull_request_review: + types: [edited, dismissed] + +jobs: + remove-review-label: + runs-on: ubuntu-latest + permissions: + pull-requests: write + + if: github.repository_owner == 'cryostatio' && contains(github.event.pull_request.labels.*.name, 'review-requested') + + steps: + - name: Checkout code + uses: actions/checkout@v2 + + - name: Remove label + run: | + pr_number=${{ github.event.pull_request.number }} + echo "Removing 'review-requested' label from the PR" + gh pr edit $pr_number --remove-label "review-requested" + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 0208929b077ff603a5b290e530d25fc3fc30789a Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 09:51:22 -0400 Subject: [PATCH 07/24] removed () on reviewers --- .github/workflows/pr-request-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index b03b1b29e5..39866df926 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -25,8 +25,8 @@ jobs: if [ -n "$reviewers" ]; then gh pr request-review ${{ github.event.issue.number }} --reviewer $reviewers else - echo "Requesting review from @cryostatio/reviewer(s) team" - gh pr request-review ${{ github.event.issue.number }} --team cryostatio/reviewer(s) + echo "Requesting review from @cryostatio/reviewers team" + gh pr request-review ${{ github.event.issue.number }} --team cryostatio/reviewers fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 1418d76e1d150c8f110ed8a4b9e528d61fc01f37 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 10:25:01 -0400 Subject: [PATCH 08/24] fixed flag --- .github/workflows/pr-request-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 39866df926..b0fce59c67 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -23,10 +23,10 @@ jobs: gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" if [ -n "$reviewers" ]; then - gh pr request-review ${{ github.event.issue.number }} --reviewer $reviewers + gh pr review ${{ github.event.issue.number }} $reviewers else echo "Requesting review from @cryostatio/reviewers team" - gh pr request-review ${{ github.event.issue.number }} --team cryostatio/reviewers + gh pr review ${{ github.event.issue.number }} cryostatio/reviewers fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From e26aacd4d7ffb560ceda68ee1db08fc2799ba9a2 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 10:48:32 -0400 Subject: [PATCH 09/24] fixes --- .github/workflows/pr-request-review.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index b0fce59c67..08ff1f6613 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -23,10 +23,12 @@ jobs: gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" if [ -n "$reviewers" ]; then - gh pr review ${{ github.event.issue.number }} $reviewers + for reviewer in $reviewers; do + gh pr review ${{ github.event.issue.number }} --approve --body "Review requested by @${reviewer}" + done else echo "Requesting review from @cryostatio/reviewers team" - gh pr review ${{ github.event.issue.number }} cryostatio/reviewers + gh pr review ${{ github.event.issue.number }} --approve --body "Review requested by @cryostatio/reviewers" fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From c28d22c202685bdebc065468b13414c8ed6b7d0c Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 11:05:03 -0400 Subject: [PATCH 10/24] more fixes --- .github/workflows/pr-request-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 08ff1f6613..d5057f1d26 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -24,11 +24,11 @@ jobs: if [ -n "$reviewers" ]; then for reviewer in $reviewers; do - gh pr review ${{ github.event.issue.number }} --approve --body "Review requested by @${reviewer}" + gh pr review ${{ github.event.issue.number }} --body "Review requested by @${reviewer}" done else echo "Requesting review from @cryostatio/reviewers team" - gh pr review ${{ github.event.issue.number }} --approve --body "Review requested by @cryostatio/reviewers" + gh pr review ${{ github.event.issue.number }} --team "Review requested by @cryostatio/reviewers" fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 7d150bfcb34f29768c654058e4aea072a92af6b6 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 11:20:26 -0400 Subject: [PATCH 11/24] more fixes --- .github/workflows/pr-request-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index d5057f1d26..c8c331b622 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -24,11 +24,11 @@ jobs: if [ -n "$reviewers" ]; then for reviewer in $reviewers; do - gh pr review ${{ github.event.issue.number }} --body "Review requested by @${reviewer}" + gh pr review ${{ github.event.issue.number }} --comment "Review requested by @${reviewer}" done else echo "Requesting review from @cryostatio/reviewers team" - gh pr review ${{ github.event.issue.number }} --team "Review requested by @cryostatio/reviewers" + gh pr review ${{ github.event.issue.number }} --comment "Review requested by @cryostatio/reviewers" fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From d5184532f4c468875382daa9552faf41b5398c1c Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 11:50:38 -0400 Subject: [PATCH 12/24] more fixes --- .github/workflows/pr-request-review.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index c8c331b622..1e8b8df1b2 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -23,12 +23,11 @@ jobs: gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" if [ -n "$reviewers" ]; then - for reviewer in $reviewers; do - gh pr review ${{ github.event.issue.number }} --comment "Review requested by @${reviewer}" - done + gh pr request-review ${{ github.event.issue.number }} --reviewer $reviewers else echo "Requesting review from @cryostatio/reviewers team" - gh pr review ${{ github.event.issue.number }} --comment "Review requested by @cryostatio/reviewers" + gh pr request-review ${{ github.event.issue.number }} --team cryostatio/reviewer fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + From 2faab001fce3e9684c84faba93bfefcbca1a03ca Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 11:53:16 -0400 Subject: [PATCH 13/24] apply fixes --- .github/workflows/pr-remove-request-review.yml | 2 +- .github/workflows/pr-request-review.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-remove-request-review.yml b/.github/workflows/pr-remove-request-review.yml index 22c6936ddc..cac197fd47 100644 --- a/.github/workflows/pr-remove-request-review.yml +++ b/.github/workflows/pr-remove-request-review.yml @@ -10,7 +10,7 @@ jobs: permissions: pull-requests: write - if: github.repository_owner == 'cryostatio' && contains(github.event.pull_request.labels.*.name, 'review-requested') + if: contains(github.event.pull_request.labels.*.name, 'review-requested') steps: - name: Checkout code diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 1e8b8df1b2..21e390406a 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest permissions: pull-requests: write - if: github.repository_owner == 'cryostatio' && github.event.issue.pull_request && startsWith(github.event.comment.body, '/request_review') + if: github.event.issue.pull_request && startsWith(github.event.comment.body, '/request_review') steps: - name: Checkout code uses: actions/checkout@v2 From 89ef4dc86b8b5696746ea995a40eada1034c0ce4 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 12:36:29 -0400 Subject: [PATCH 14/24] test24 --- .github/workflows/pr-request-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 21e390406a..dae8f92b20 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -23,10 +23,10 @@ jobs: gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" if [ -n "$reviewers" ]; then - gh pr request-review ${{ github.event.issue.number }} --reviewer $reviewers + gh pr create ${{ github.event.issue.number }} --reviewer $reviewers else echo "Requesting review from @cryostatio/reviewers team" - gh pr request-review ${{ github.event.issue.number }} --team cryostatio/reviewer + gh pr create ${{ github.event.issue.number }} --reviewer cryostatio/reviewers fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 3074b1c2c83d6df7726bed0cb809f2ec4c7d89bd Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 12:52:44 -0400 Subject: [PATCH 15/24] test24 --- .github/workflows/pr-request-review.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index dae8f92b20..9bb7eb75f9 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -18,16 +18,17 @@ jobs: - name: Add label and request review run: | reviewers="@cryostatio/reviewers" + pr_number=${{ github.event.issue.number }} echo "Adding label 'review-requested' to the PR" - gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" + gh pr edit $pr_number --add-label "review-requested" if [ -n "$reviewers" ]; then - gh pr create ${{ github.event.issue.number }} --reviewer $reviewers + gh pr create --reviewer $reviewers else echo "Requesting review from @cryostatio/reviewers team" - gh pr create ${{ github.event.issue.number }} --reviewer cryostatio/reviewers + gh pr create --reviewer cryostatio/reviewers fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - +#test23 From 0a44884cc8f568ae29c5999b34f7c8ba8430c4d8 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 13:21:50 -0400 Subject: [PATCH 16/24] test25 --- .github/workflows/pr-request-review.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 9bb7eb75f9..c78424bed2 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -17,18 +17,17 @@ jobs: - name: Add label and request review run: | - reviewers="@cryostatio/reviewers" - pr_number=${{ github.event.issue.number }} + reviewers="@mwangggg" echo "Adding label 'review-requested' to the PR" - gh pr edit $pr_number --add-label "review-requested" + gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" if [ -n "$reviewers" ]; then - gh pr create --reviewer $reviewers + gh pr edit ${{ github.event.issue.number }} --add-reviewer $reviewers else echo "Requesting review from @cryostatio/reviewers team" - gh pr create --reviewer cryostatio/reviewers + gh pr edit ${{ github.event.issue.number }} --add-reviewer cryostatio/reviewers fi env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} -#test23 + From d11da5b5a6e0b02e23c29e3342c491f93a9bd042 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 13:24:42 -0400 Subject: [PATCH 17/24] test25 --- .github/workflows/pr-request-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index c78424bed2..661cfcb8b9 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -17,7 +17,7 @@ jobs: - name: Add label and request review run: | - reviewers="@mwangggg" + reviewers="mwangggg" echo "Adding label 'review-requested' to the PR" gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" From 86e014ae6819341e128b26dbc0b660f8d3a05993 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 13:40:45 -0400 Subject: [PATCH 18/24] test25 --- .github/workflows/pr-remove-request-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-remove-request-review.yml b/.github/workflows/pr-remove-request-review.yml index cac197fd47..a6dc25db3c 100644 --- a/.github/workflows/pr-remove-request-review.yml +++ b/.github/workflows/pr-remove-request-review.yml @@ -2,7 +2,7 @@ name: Remove Review Label on: pull_request_review: - types: [edited, dismissed] + types: [submitted, edited, dismissed] jobs: remove-review-label: From abe989e3271443380880b00f69541de9e49ef2ba Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 16:11:12 -0400 Subject: [PATCH 19/24] test26 --- .github/workflows/pr-request-review.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 661cfcb8b9..e4752377d4 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -22,12 +22,10 @@ jobs: echo "Adding label 'review-requested' to the PR" gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" - if [ -n "$reviewers" ]; then - gh pr edit ${{ github.event.issue.number }} --add-reviewer $reviewers - else echo "Requesting review from @cryostatio/reviewers team" - gh pr edit ${{ github.event.issue.number }} --add-reviewer cryostatio/reviewers - fi + for reviewer in $reviewers; do + gh pr edit ${{ github.event.issue.number }} --add-reviewer $reviewer + done env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 3d427c1fd82002dd0401296d8f24097403df49fe Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 16:19:54 -0400 Subject: [PATCH 20/24] test26 --- .github/workflows/pr-request-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index e4752377d4..3674f53390 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -17,7 +17,7 @@ jobs: - name: Add label and request review run: | - reviewers="mwangggg" + reviewers="mwangggg aali309" echo "Adding label 'review-requested' to the PR" gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" From b7ed6bebd08bf031baee7a740aaf56877a38f809 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 16:21:20 -0400 Subject: [PATCH 21/24] test29 --- .github/workflows/pr-request-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 3674f53390..964dba38af 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -17,7 +17,7 @@ jobs: - name: Add label and request review run: | - reviewers="mwangggg aali309" + reviewers="aali309" echo "Adding label 'review-requested' to the PR" gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" From 827111fdbf61a79c1f33af3fdc8fce7758be67d7 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 1 Sep 2023 16:32:00 -0400 Subject: [PATCH 22/24] test30 --- .github/workflows/pr-request-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-request-review.yml b/.github/workflows/pr-request-review.yml index 964dba38af..bd6dfab291 100644 --- a/.github/workflows/pr-request-review.yml +++ b/.github/workflows/pr-request-review.yml @@ -17,7 +17,7 @@ jobs: - name: Add label and request review run: | - reviewers="aali309" + reviewers="ashihab20" echo "Adding label 'review-requested' to the PR" gh pr edit ${{ github.event.issue.number }} --add-label "review-requested" From cd52f141e037a311bf39333237ce6dc7fd2fdd07 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 20 Sep 2023 13:27:52 -0400 Subject: [PATCH 23/24] update --- .../workflows/pr-remove-request-review.yml | 25 ------------------- 1 file changed, 25 deletions(-) delete mode 100644 .github/workflows/pr-remove-request-review.yml diff --git a/.github/workflows/pr-remove-request-review.yml b/.github/workflows/pr-remove-request-review.yml deleted file mode 100644 index a6dc25db3c..0000000000 --- a/.github/workflows/pr-remove-request-review.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Remove Review Label - -on: - pull_request_review: - types: [submitted, edited, dismissed] - -jobs: - remove-review-label: - runs-on: ubuntu-latest - permissions: - pull-requests: write - - if: contains(github.event.pull_request.labels.*.name, 'review-requested') - - steps: - - name: Checkout code - uses: actions/checkout@v2 - - - name: Remove label - run: | - pr_number=${{ github.event.pull_request.number }} - echo "Removing 'review-requested' label from the PR" - gh pr edit $pr_number --remove-label "review-requested" - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 859602209f7f6970055823d4f1da31ce7b21772c Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Thu, 9 Nov 2023 09:14:48 -0500 Subject: [PATCH 24/24] typo in CI workflow --- .github/workflows/integrated-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/integrated-test.yml b/.github/workflows/integrated-test.yml index 5f60f808f9..943a8b253f 100644 --- a/.github/workflows/integrated-test.yml +++ b/.github/workflows/integrated-test.yml @@ -74,4 +74,4 @@ jobs: run: ls -1dt target/cryostat-itest-*.log | head -n1 | xargs cat - name: Print itest container logs if: failure() - run: ls -1dt target/cryostat-*.server.log | head -n1 | xargs catyea + run: ls -1dt target/cryostat-*.server.log | head -n1 | xargs cat