-
Notifications
You must be signed in to change notification settings - Fork 274
chore: fix inconsistent struct name in comment #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated a comment in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
proto/cronos/query.proto (1)
34-35: Nit: stray double period in comment."Params queries permissions for a specific address.." → remove one period.
- // Params queries permissions for a specific address.. + // Params queries permissions for a specific address.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
proto/cronos/query.proto(1 hunks)
🔇 Additional comments (1)
proto/cronos/query.proto (1)
55-55: LGTM: fixed the response type name in the comment.The comment now correctly references ContractByDenomResponse and matches the RPC signature and message below. No behavioral impact.
|
please verify your commits |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
===========================================
+ Coverage 16.87% 35.47% +18.60%
===========================================
Files 72 127 +55
Lines 6163 9730 +3567
===========================================
+ Hits 1040 3452 +2412
- Misses 5000 5910 +910
- Partials 123 368 +245 🚀 New features to boost your workflow:
|
Signed-off-by: zhedazijingang <unwrap_or_else@outlook.com>
|
Executed and signed. Please review again. |
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)fix inconsistent struct name in comment
Summary by CodeRabbit