Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird message in status window when opening a session #33

Open
anarcat opened this issue May 11, 2013 · 4 comments
Open

weird message in status window when opening a session #33

anarcat opened this issue May 11, 2013 · 4 comments

Comments

@anarcat
Copy link
Contributor

anarcat commented May 11, 2013

I see this when an OTR session is negotiated:

12:43:03 [IMC]  -!- [chat0.koumbit.net] <b>anarcat@localhost</b> Unknown command
12:43:06 [IMC]  -!- [chat0.koumbit.net] See Unknown command

chat0.koumbit.net is the IRC server I am on while negotiating a private OTR conversation. This looks an awful lot like parts of the message sent to the other party when initating the conversation ( foo has requested an OTR conversation, see foobar.com for more information...)

@dgoulet
Copy link
Member

dgoulet commented Jun 9, 2013

Yes so libotr uses a html formatted text in a message for the case the remote user does NOT have otr. Irssi does not behave well with html tags thus why you see that.

This is why irssi-otr does not use the default message of libotr for that but pidgin for instance does use it...

Apart from stripping the html tags from the incoming message in irssi-otr, this will continue to happen...

Thoughts?

@anarcat
Copy link
Contributor Author

anarcat commented Jun 10, 2013

That is not the problem. The problem is that this message shows up in the status window, not the chat window. Even worse, it looks like the text is being parsed as a command which makes me worried about remote execution.

@dgoulet
Copy link
Member

dgoulet commented Sep 6, 2013

I'm still investigating this one because you are right this can be really BAD if irssi tries to interpret this as a command.

Currently, I'm unable to reproduce it though... do you have a reliable way to reproduce it each time ? However, I remember seeing this issue so I'll investigate more this issue and flagging it as a security issue until we can sort this one out.

@dgoulet
Copy link
Member

dgoulet commented Nov 9, 2013

So this is due to the default OTR message containing html tags and telling the other side that basically you don't have OTR support you can go to a website to get it. Irssi does not handle well html tags so there is no risk for remote execution since it is prefixed by "" and your nickname follows.

I'll ask upstream libotr to maybe reconsider using html and \n in that message.

It can be reproduce simply by typing "?OTR?" in the private message window. That tag triggers the default messsage to be sent by libotr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants