Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle "argument list too long" #40

Open
kzidane opened this issue Dec 12, 2019 · 3 comments
Open

handle "argument list too long" #40

kzidane opened this issue Dec 12, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kzidane
Copy link
Member

kzidane commented Dec 12, 2019

When trying to submit too many files (e.g., their node_modules or virtual environment files). Ideally these files should be ignored but they shouldn't cause our tools to break if they're not.

@cmlsharp
Copy link
Contributor

This is an OS-imposed limit. Things like rm, cp, etc. will break too for the same reason. We could let patterns be specified as strings and glob them ourselves I guess (though the number of patterns is still limited of course)

@kzidane
Copy link
Member Author

kzidane commented Apr 10, 2020

Yeah, I understand that. What I had in mind was detect whatever error message git shows up in this case and show a more friendly output with a hint or two maybe instead of saying "something went wrong". Alternatively, maybe we could run git add once per listing though that might end up being significantly slower.

@cmlsharp
Copy link
Contributor

cmlsharp commented Apr 11, 2020

Oh that's where the error is showing up, right. I forgot you can't specify files manually to check/submit50 anymore.

It's way way slower to run git add for each file even for something like finance. I remember making that change.

Hmm... I wonder if we can get that value dynamically and do it in batches. Otherwise we could find the lowest number that reasonable platforms allow and use that.

@kzidane kzidane added the bug Something isn't working label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants