Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rounding as well as truncating in volume #253

Open
chriscarrollsmith opened this issue Jul 6, 2024 · 2 comments
Open

Allow rounding as well as truncating in volume #253

chriscarrollsmith opened this issue Jul 6, 2024 · 2 comments
Assignees
@guyewhite @yuliiazhukovetsHU

Comments

@chriscarrollsmith
Copy link

chriscarrollsmith commented Jul 6, 2024 •
edited
Loading

check50 cs50/problems/2024/x/volume returns failed tests if you use the round function after multiplying by the scaling factor. Rounding is arguably more correct than simply coercing the result back to an integer, which truncates the resulting number.
@rongxin-liu rongxin-liu transferred this issue from cs50/check50 Jul 7, 2024
@guyewhite
Copy link

@yuliiazhukovetsHU Are you a pro at checks? I've actually never written one! I'd sure like to learn!

@goyalyashpal
Copy link

I think this issue can be closed per the merged request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyewhite guyewhite

@yuliiazhukovetsHU yuliiazhukovetsHU

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goyalyashpal @guyewhite @chriscarrollsmith @yuliiazhukovetsHU