Skip to content

Commit 3ff95ab

Browse files
authored
Merge pull request #47 from tanhongit/refactor-events
(#42) add conditions to check and exclude invalid chat ids
2 parents d84e1e4 + 857284b commit 3ff95ab

File tree

3 files changed

+28
-0
lines changed

3 files changed

+28
-0
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?php
2+
/**
3+
* @var $payload mixed
4+
*/
5+
6+
$message = "👷‍♂️🛠️ <b>Dismissed Pull Request Review Comment</b> - <a href=\"{$payload->pull_request->html_url}\">{$payload->repository->full_name}#{$payload->pull_request->number}</a> by <a href=\"{$payload->review->user->html_url}\">@{$payload->review->user->login}</a>\n\n";
7+
8+
$message .= "🛠 <b>{$payload->pull_request->title}</b> \n\n";
9+
10+
$message .= "🔗 Link: <a href=\"{$payload->review->html_url}\">{$payload->review->html_url}</a>\n\n";
11+
12+
echo $message;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?php
2+
/**
3+
* @var $payload mixed
4+
*/
5+
6+
$message = "👷‍♂️🛠️ <b>New Pull Request Review Comment</b> - <a href=\"{$payload->pull_request->html_url}\">{$payload->repository->full_name}#{$payload->pull_request->number}</a> by <a href=\"{$payload->review->user->html_url}\">@{$payload->review->user->login}</a>\n\n";
7+
8+
$message .= "🛠 <b>{$payload->pull_request->title}</b> \n\n";
9+
10+
$message .= "🔗 Link: <a href=\"{$payload->review->html_url}\">{$payload->review->html_url}</a>\n\n";
11+
12+
echo $message;

src/Http/Actions/SendNotifyAction.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ public function __invoke(): void
5555
if (!is_null($this->request->server->get('HTTP_X_GITHUB_EVENT')) && empty($chatMessageId)) {
5656
$this->notificationService->setPayload($this->request);
5757
foreach ($this->chatIds as $chatId) {
58+
if (empty($chatId)) {
59+
continue;
60+
}
61+
5862
$this->notificationService->sendNotify($chatId);
5963
}
6064
}

0 commit comments

Comments
 (0)