Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated notebooks #1290

Open
5 tasks
maxnoe opened this issue Sep 17, 2024 · 1 comment
Open
5 tasks

Outdated notebooks #1290

maxnoe opened this issue Sep 17, 2024 · 1 comment

Comments

@maxnoe
Copy link
Member

maxnoe commented Sep 17, 2024

While replacing the gamma test file with the newer, lstprod2 version, I found that some notebooks no longer work with current lstchain and its dependencies:

  • notebooks/disp.ipynb

    TypeError: CameraCalibrator.__init__() missing 1 required positional argument: 'subarray'
  • notebooks/example_container.ipynb

    TypeError: CameraCalibrator.__init__() missing 1 required positional argument: 'subarray'
  • notebooks/lstchain.ipynb

    ImportError                               Traceback (most recent call last)
    Cell In[5], line 3
          1 # Take a look at the parameters extracted from the simtelarray file:
    ----> 3 from lstchain.tests.test_lstchain import dl1_file, dl1_params_lstcam_key
          5 data = pd.read_hdf(output_filename, key=dl1_params_lstcam_key)
          6 print(data.keys())
    
        ImportError: cannot import name 'dl1_file' from 'lstchain.tests.test_lstchain' ([/home/mnoethe/Uni/LST/cta-lstchain/lstchain/tests/test_lstchain.py](http://localhost:8888/lab/tree/notebooks/lstchain/tests/test_lstchain.py))
    
  • notebooks/calculate_sensitivity_eventio.ipynb uses pyhessio

  • notebooks/step_by_step_dl0_to_dl1.ipynb uses pyhessio and:

    ---------------------------------------------------------------------------
    ImportError                               Traceback (most recent call last)
    Cell In[1], line 7
          4 import astropy.units as u
          5 from copy import deepcopy
    ----> 7 from lstchain.calib import lst_calibration
          8 from ctapipe.image import hillas_parameters
         10 import pyhessio
    
    ImportError: cannot import name 'lst_calibration' from 'lstchain.calib' ([/home/mnoethe/Uni/LST/cta-lstchain/lstchain/calib/__init__.py](http://localhost:8888/lab/tree/notebooks/lstchain/calib/__init__.py))
    
@morcuended
Copy link
Member

morcuended commented Sep 17, 2024

related #1091, I think we should make the effort to clean and update the notebooks and try to CI test them using test data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants