Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we deprecate changed config options? #2521

Open
kosack opened this issue Mar 6, 2024 · 0 comments
Open

Should we deprecate changed config options? #2521

kosack opened this issue Mar 6, 2024 · 0 comments
Milestone

Comments

@kosack
Copy link
Contributor

kosack commented Mar 6, 2024

In #2520, I changed a bunch of config option names, which will break existing config files. Maybe before release the next version we should add back in the old options, but with a deprecation warning? (e.g. put them back in, but with an @observe function that issues a more useful error like:

The config option write_images is now write_dl1_images, please update your configuration file

Would this be useful? Or just confusing? It could even simply forward those options to the new version, so old config files would work, but with a warning until the next release.

@kosack kosack added this to the v0.21.0 milestone Mar 21, 2024
@maxnoe maxnoe modified the milestones: v0.21.0, 0.22.0 Mar 22, 2024
@maxnoe maxnoe modified the milestones: 0.22.0, 0.23.0 Sep 10, 2024
@maxnoe maxnoe modified the milestones: 0.23.0, 0.24.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants