Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psf model to InstrumentDescription #2647

Open
ctoennis opened this issue Nov 12, 2024 · 0 comments
Open

Add psf model to InstrumentDescription #2647

ctoennis opened this issue Nov 12, 2024 · 0 comments
Assignees

Comments

@ctoennis
Copy link

The InstrumentDescription model should have a place to store the upcoming PSFModel in PR #2643 for each telescope, ideally somewhere in OpticsDescription.

Describe the solution you'd like
The instrument module is where we define the InstrumentDescription model (which currently is collected under SubarrayDescription class in ctapipe). It would be useful then to integrate it with the rest of the model, i.e. add a place for it in OpticsDescription, and add serialization so that it can be written and read. A collection of these could be serialized to a new table (one row per telescope), as we do with other OpticsDescription parts (SubarrayDescription.to_table(kind="optical_psf"), or else just in OpticsDescription... ) .

psf : Optional[PSFModel]  = subarray.tel[tel_id].optics.psf

if psf: 
     plot_psf(psf)  # some general function that plots any PSFModel

Additional context
The PSFModel is found in in PR #2643

@ctoennis ctoennis self-assigned this Nov 12, 2024
@ctoennis ctoennis mentioned this issue Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant