Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fragments #121

Open
ecker00 opened this issue Jan 6, 2023 · 0 comments
Open

Support for fragments #121

ecker00 opened this issue Jan 6, 2023 · 0 comments

Comments

@ecker00
Copy link

ecker00 commented Jan 6, 2023

Seems that the way the client builds it's queries right now it omits fragments, leaving them in the raw query but no reference to their structure. So it sends off requests without fragment details.

Example it generates code like this:

func NewGetAccountMeRequest(url string) (*GetAccountMeRequest, error) {
	b, err := json.Marshal(&GraphQLOperation{
		Query: `query getAccountMe {
  accountMe {
    ...AccountFields
  }
}`,
	})
	if err != nil {
		return nil, err
	}
	req, err := http.NewRequest(http.MethodPost, url, bytes.NewReader(b))
	if err != nil {
		return nil, err
	}
	req.Header.Set("Content-Type", "application/json")
	return &GetAccountMeRequest{req}, nil
}

But it should include a fragment section in the Query like this:

Query: `query getAccountMe {
  accountMe {
    ...AccountFields
  }
}
fragment AccountFields on Account {
  id
  email
  username
}`,
…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant