Migration/Clone events may be slow

[ChemiKyle]

Using the XML from #14 I noticed that trying to migrate/clone the "Bai" data collection instrument was very slow. After clicking either option there was no indication that anything was happening. I was able to try to cancel the dialog box which resulted in the form's complete status not migrating! We should add a little spinner to the selection and maybe disable the buttons after clicking.

Hook the AJAX call here:

move_data_to_other_event/js/mdoe.js

Line 194 in 24fdef6

function ajaxMoveEvent(sourceEventId, targetEventId, formNames = null, deleteSourceData = false) {

If you need to add any parameters to the response, they can be included in the delete_response array returned by moveEvent:

move_data_to_other_event/ExternalModule.php

Line 145 in 24fdef6

return json_encode($delete_response);

UI updated in PR #17, I am leaving this issue open as a reminder to look for ways to optimize performance where possible.

---

Additionally I should probably optimize, I suspect I can save some speed here with by checking for edocs:

move_data_to_other_event/ExternalModule.php

Line 117 in 24fdef6

$log_message = $this->forceMigrateSourceFields($get_data, $project_id, $record_id, $source_event_id, $target_event_id, $log_message);

[ChemiKyle]

Unfortunately the slowness seems to be due to the core REDCap::saveData rather than my code.

I did some profiling using the same XML stated in the start of this issue, which has 1649 fields across 38 forms. I believe this function scales with a combination of these 2 factors (a quick and dirty calculation supports O(fields * ln(forms)).

---

Timing just after this step:

move_data_to_other_event/ExternalModule.php

Line 100 in 24fdef6

$new_data[$record_id][$target_event_id] = $old_data[$record_id][$source_event_id];

It takes about 25 seconds to complete this line:

move_data_to_other_event/ExternalModule.php

Line 105 in 24fdef6

$log_message = "Migrated form(s) " . $form_names . " from event " . $source_event_id . " to " . $target_event_id;

Which is due to redcap core.

The recursive array walk takes about half a millisecond:

move_data_to_other_event/ExternalModule.php

Lines 107 to 108 in 24fdef6

	// soft delete all data for each field
	array_walk_recursive($old_data[$record_id][$source_event_id], function(&$value, $key) use ($record_pk) {

After which t takes an additional 28.5 seconds to complete this line:

move_data_to_other_event/ExternalModule.php

Line 114 in 24fdef6

$delete_response = REDCap::saveData($project_id, 'array', $old_data, 'overwrite');

[michael-bentz]

Migrated UI changes to issue #18.