Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gluer doesn't extract jump targets within if-delimited blocks #43

Open
epeguero opened this issue Jun 27, 2020 · 2 comments
Open

Gluer doesn't extract jump targets within if-delimited blocks #43

epeguero opened this issue Jun 27, 2020 · 2 comments
Assignees
Labels
it's all up to PHIL Phil MUST click THE BUTTON and agrees to take ALL responsibility!!!!! Neil is the Master of Merges

Comments

@epeguero
Copy link
Contributor

The gluer can extract if delimited blocks, but it currently doesn't bring in its corresponding jump targets.

Building programs-phil/spad/if-delim-test shows that these labels can occur after the return instruction (e.g., jr ra, ret, etc.), so at least these "auxiliary labels" must be extracted and glued as well. (The gluing function already implements this functionality for scalar code). This might be sufficient in most cases if we assume "if" branch targets are always placed at the end; otherwise, we'll have to bring in all of the vector code labels just in case.

Let me know if you guys want to take a stab at this one, or if you'd prefer if I implemented this.

@epeguero epeguero added it's all up to PHIL Phil MUST click THE BUTTON and agrees to take ALL responsibility!!!!! Neil is the Master of Merges labels Jun 27, 2020
@pbb59
Copy link
Collaborator

pbb59 commented Jun 27, 2020

I would be surprised if the branch targets are always placed after the return of the function. But others might know more.

@epeguero
Copy link
Contributor Author

epeguero commented Jun 28, 2020

I would be surprised if the branch targets are always placed after the return of the function. But others might know more.

Probably not a good assumption, though it might work for some benchmarks (e.g., programs-phil/spad/if-delim-test). Regardless, labels after ret must be extracted. This is the remaining functionality to implement, since 'junk' blocks can be repurposed as auxiliary blocks for if-blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
it's all up to PHIL Phil MUST click THE BUTTON and agrees to take ALL responsibility!!!!! Neil is the Master of Merges
Projects
None yet
Development

No branches or pull requests

4 participants