Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an allowList like nativeAllowList that allows all custom nodes to have allowed exceptions. #43

Open
clord opened this issue Dec 16, 2020 · 3 comments · May be fixed by #73
Open

add an allowList like nativeAllowList that allows all custom nodes to have allowed exceptions. #43

clord opened this issue Dec 16, 2020 · 3 comments · May be fixed by #73

Comments

@clord
Copy link

clord commented Dec 16, 2020

emotion allows css={[aRules, bRules]} and does the right thing for re-rendering, so it should not be flagged as a performance issue. We can turn this off for native elements like div, but css is allowed on any element, including custom elements.

There are other examples like this, for example, I can accept style on a custom element and pass it unchanged to the native one, and so would make sense to allow style as an exception on custom elements too.

@amsul
Copy link

amsul commented Jan 29, 2021

Would love to see something like this! @cvazac is this something you'd consider merging if we submit a PR for it?

@cvazac
Copy link
Owner

cvazac commented Jan 30, 2021

@amsul absolutely, it’s a great idea.

@milesj
Copy link

milesj commented Jun 29, 2021

This would be useful for RN props also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants