Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-perf/jsx-no-jsx-as-prop listed as part of recommended in README.md, but isn't #55

Open
bryan-codaio opened this issue Jan 9, 2023 · 2 comments · May be fixed by #75
Open

react-perf/jsx-no-jsx-as-prop listed as part of recommended in README.md, but isn't #55

bryan-codaio opened this issue Jan 9, 2023 · 2 comments · May be fixed by #75

Comments

@bryan-codaio
Copy link

bryan-codaio commented Jan 9, 2023 •
edited
Loading

Commit 2d81814 added the new jsx-no-jsx-as-prop rule and added it immediately to the recommended configuration. However, commit 8f121da then removed it from recommended, notably without updating the README.md.

I could submit a pull request to update the README.md to match the code. Before I do that, though, I was wondering if there's any context on why this was not a recommended rule? Commit 8f121da doesn't provide any context
@huynhducduy huynhducduy linked a pull request Nov 30, 2024 that will close this issue
Open
@cvazac
Copy link
Owner

cvazac commented Jan 7, 2025

@bryan-codaio thanks for your patience!

I don't know why jsx-no-jsx-as-prop was removed from recommended. I think it should be added back, wdyt?

@bryan-codaio
Copy link
Author

yeah, it strikes me that it ought to be in the recommended config unless there's a specific reason otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cvazac @bryan-codaio