From 59a7c0de93f2756ee62660862ed23e9c48675235 Mon Sep 17 00:00:00 2001 From: Mark Raasveldt Date: Tue, 26 Sep 2023 07:24:14 +0200 Subject: [PATCH 1/2] No longer build i686 wheels for Python --- .github/workflows/Python.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/Python.yml b/.github/workflows/Python.yml index b6cea0122ae..20eff234060 100644 --- a/.github/workflows/Python.yml +++ b/.github/workflows/Python.yml @@ -131,7 +131,7 @@ jobs: runs-on: ubuntu-20.04 strategy: matrix: - arch: [i686, x86_64, aarch64] + arch: [x86_64, aarch64] python_build: [cp37-*, cp38-*, cp39-*, cp310-*, cp311-*] isRelease: - ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }} @@ -144,15 +144,13 @@ jobs: python_build: 'cp39-*' - isRelease: false python_build: 'cp311-*' - - isRelease: false - arch: i686 - isRelease: false arch: aarch64 needs: manylinux-extensions-x64 env: CIBW_BUILD: ${{ matrix.python_build}} CIBW_SKIP: '*-musllinux_aarch64' - CIBW_ARCHS: ${{ matrix.arch == 'i686' && 'auto32' || matrix.arch == 'aarch64' && 'aarch64' || 'auto64' }} + CIBW_ARCHS: ${{ matrix.arch == 'aarch64' && 'aarch64' || 'auto64' }} SETUPTOOLS_SCM_NO_LOCAL: 'yes' PYTEST_TIMEOUT: '600' DUCKDB_BUILD_UNITY: 1 From 946c60a259c9666bfbbc9ad0609247824df73cb6 Mon Sep 17 00:00:00 2001 From: Carlo Piovesan Date: Tue, 26 Sep 2023 09:38:55 +0200 Subject: [PATCH 2/2] Python: skip test depending on garbage collector behaviour --- tools/pythonpkg/tests/fast/api/test_read_csv.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/pythonpkg/tests/fast/api/test_read_csv.py b/tools/pythonpkg/tests/fast/api/test_read_csv.py index b49170b6abc..949ec73219b 100644 --- a/tools/pythonpkg/tests/fast/api/test_read_csv.py +++ b/tools/pythonpkg/tests/fast/api/test_read_csv.py @@ -398,6 +398,7 @@ def test_filelike_none(self, duckdb_cursor): with pytest.raises(ValueError, match="Can not read from a non file-like object"): res = duckdb_cursor.read_csv(obj, header=True).fetchall() + @pytest.mark.skip(reason="depends on garbage collector behaviour, and sporadically breaks in CI") def test_internal_object_filesystem_cleanup(self, duckdb_cursor): _ = pytest.importorskip("fsspec")