Debug

Author: cwindolf

src/dartsort/cli.py

@@ -45,7 +45,6 @@ def dartsort_cli():
     cli_util.dataclass_to_argparse(
         config.DeveloperConfig,
         parser=dev_args,
-        prefix="_",
         skipnames=cli_util.fieldnames(config.DARTsortUserConfig),
     )
 

src/dartsort/peel/peel_base.py

@@ -650,7 +650,7 @@ def check_resuming(self, output_hdf5_filename, overwrite=False):
         exists = output_hdf5_filename.exists()
         last_chunk_start = -1
         if exists and not overwrite:
-            with h5py.File(output_hdf5_filename, "r") as h5:
+            with h5py.File(output_hdf5_filename, "r", locking=False) as h5:
                 last_chunk_start = h5["last_chunk_start"][()]
         return last_chunk_start
 

src/dartsort/util/internal_config.py

@@ -338,7 +338,7 @@ class RefinementConfig:
     # if None, switches to bimodality
     merge_criterion_threshold: float | None = 0.0
     merge_criterion: Literal[
-        "heldout_loglik", "heldout_ccl", "loglik", "ccl", "aic", "bic", "icl"
+        "heldout_loglik", "heldout_ccl", "loglik", "ccl", "aic", "bic", "icl", "bimodality"
     ] = "heldout_ccl"
     merge_bimodality_threshold: float = 0.05
     em_converged_prop: float = 0.02

src/dartsort/util/noise_util.py

@@ -432,6 +432,9 @@ def marginal_covariance(
             if device is not None and device != res.device:
                 res = res.to(device)
                 self.cache[cache_key] = res
+            # TODO: why is this necessary? I thought that calling solve would cache this.
+            if not hasattr(res, '_memoize_cache'):
+                res.cholesky()
             return res
         if channels is None or channels == slice(None):
             if self._full_cov is None: