JUnit dependency should be test scope

[scotthraban]

Summary

JUnit is a test library, and as such should be made test scope in the POM, so as to prevent forcing a test library as a transient dependency on consumers of the library.

Steps to Reproduce

1. Run mvn dependency:tree -Dincludes=junit:junit

Expected Results

Dependency definition is test.

Actual Results (including error logs, if applicable)

Dependency definition is compile.

Reproducible

• Always
• Sometimes
• Non-Reproducible

Version/Tag number

3.0.5

Environment setup

N/A - Build issue.

Additional Information

b002c04#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R187-R190

Dependency should have been added with test scope, as was previously on the cucumber-junit library that junit replaced.

[szh]

Thank you for the issue. Would you like to submit a PR to fix this?

[scotthraban]

@szh sure thing, please see #122.

[szh]

@gl-johnson can you please review this, given your Java knowledge is superior to mine? It's PR #123