Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Enrollment Secrets Add should be part of the script #161

Open
tzheleznyak opened this issue Nov 29, 2020 · 3 comments
Open

Auto Enrollment Secrets Add should be part of the script #161

tzheleznyak opened this issue Nov 29, 2020 · 3 comments

Comments

@tzheleznyak
Copy link

tzheleznyak commented Nov 29, 2020

All the part here of adding secrets from the k8s/openshift to DAP master
https://docs.cyberark.com/Product-Doc/OnlineHelp/AAM-DAP/Latest/en/Content/Integrations/ConjurDeployFollowers.htm?tocpath=Setup%7CConfigure%20DAP%20Followers%7C_____2#ConfigureDAPforautoenrollmentofFollowers

Should be done as part of the script and not manually by the user

Motivation :
Currently the user who runs the KCD in order to deploy just a follower to an existing DAP master should store K8S/OCP tokens in the master node in order the master and follower can authenticate each other and start replicating. Even it is the the commands the user need to run. I think adding them to the script could be a good idea so a user will just clone the repo configure in bootstrap his env variables and run it.

In addition if STOP_RUNNING_ENV =TRUE and the user runs the script for a second time on or cluster with k8s namespace same as the user gave it will override the secrets in k8s/OCP and the secret in the DAP master will be diffrent from the followers k8s secret so the communication will fail. So if after the script will create new secret it will store it in the DAP master the script users won't need to face this problem .

@doodlesbykumbi
Copy link
Contributor

Hi @tzheleznyak. Thanks for adding this issue. The motivation behind this issue isn't immediately obvious for me. Would you mind adding it to the description please ? I think doing so would allow anyone else who might come across the issue to better understand the issue.

@tzheleznyak
Copy link
Author

Hi @tzheleznyak. Thanks for adding this issue. The motivation behind this issue isn't immediately obvious for me. Would you mind adding it to the description please ? I think doing so would allow anyone else who might come across the issue to better understand the issue.

Added motivation section

@doodlesbykumbi
Copy link
Contributor

@tzheleznyak Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants