add design doc about restore processes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llamerada-jp
force-pushed
the
restore-design-doc
branch
from
801a9e5
to
204f14c
Compare
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
llamerada-jp
force-pushed
the
restore-design-doc
branch
from
204f14c
to
e8dac5d
Compare
satoru-takeuchi
requested changes
Jul 11, 2024
docs/design.md
Outdated
|
|
||
| 1. Users delete the `MantleRestore` resource. | ||
| 2. The controller tries to delete the PV/PVC created by the `MantleRestore` resource and wait until the PV/PVC is deleted. If the PV/PVC is used by some pod. | ||
| 3. The controller removes the RBD clone created by the `MantleRestore` resource. The controller should not remove RBD clone volume specified by the PV. |
There was a problem hiding this comment.
The controller should not remove RBD clone volume specified by the PV.
Could you tell me the difference between RBD clone and RBD clone volume? Are they mean the same thing? If so, the first sentence describes the controller removes the RBD clone image and the second sentence describes the controllere should not do so.
There was a problem hiding this comment.
The original sentence was misleading. I updated.
Co-authored-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
llamerada-jp
force-pushed
the
restore-design-doc
branch
from
1e57133
to
c39b660
Compare
satoru-takeuchi
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.