Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Quote table name bug #49

Closed
1 task done
yuriyua opened this issue Jan 28, 2022 · 0 comments · Fixed by #151
Closed
1 task done

🐛 Quote table name bug #49

yuriyua opened this issue Jan 28, 2022 · 0 comments · Fixed by #151
Assignees
@roxblnfk @msmakouz
Labels
status:to be verified Needs to be reproduced and validated. type:bug Bug
Milestone
2.7.x

Comments

@yuriyua
Copy link

yuriyua commented Jan 28, 2022

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

Database

MSSQL

What happened?

A bug happened!

->leftJoin('_1SCONST _1SCONST2(NOLOCK)')
->on('SC3271.ID', '=', '_1SCONST2.OBJID')

output

LEFT JOIN _1[SCONST] _1SCONST2([NOLOCK])
    ON [SC3271].[ID] = [_1SCONST2].[OBJID]

there is issue here

LEFT JOIN _1[SCONST]

=>

LEFT JOIN [_1SCONST]

Version

database 2.0
PHP 8.1
@yuriyua yuriyua added status:to be verified Needs to be reproduced and validated. type:bug Bug labels Jan 28, 2022
@roxblnfk roxblnfk moved this to Backlog in Cycle Jan 28, 2022
@roxblnfk roxblnfk added this to Cycle Jan 28, 2022
@roxblnfk roxblnfk moved this from Backlog to Discuss in Cycle Aug 8, 2022
@roxblnfk roxblnfk moved this from Discuss to Todo in Cycle Oct 11, 2022
@msmakouz msmakouz moved this from Todo to In Progress in Cycle Dec 8, 2023
@msmakouz msmakouz self-assigned this Dec 8, 2023
@msmakouz msmakouz mentioned this issue Dec 21, 2023
Merged
2 tasks
@msmakouz msmakouz linked a pull request Dec 21, 2023 that will close this issue
Fix quoting with an underscore at the beginning #151
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cycle Dec 21, 2023
@roxblnfk roxblnfk added this to the 2.7.x milestone Dec 21, 2023
@roxblnfk roxblnfk moved this from Done to Released in Cycle Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roxblnfk roxblnfk

@msmakouz msmakouz

Labels
status:to be verified Needs to be reproduced and validated. type:bug Bug
Projects
Cycle
Status: Released
Milestone
2.7.x
Development

Successfully merging a pull request may close this issue.

Fix quoting with an underscore at the beginning cycle/database
3 participants
@roxblnfk @yuriyua @msmakouz