Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from react-virtualized #1555

Open
markerikson opened this issue Jun 25, 2024 · 1 comment
Open

Migrate away from react-virtualized #1555

markerikson opened this issue Jun 25, 2024 · 1 comment

Comments

@markerikson
Copy link

Hi! We've got a fork at https://github.com/replayio-public/cypress-realworld-app that we've been using to generate Cypress runs for use with Replay.io.

I'm in the process of getting our fork set up to build with React 18 and 19, and saw that both MUI v4 and react-virtualized broke with React 19 due to uses of findDOMNode.

I looked over here and saw that #1418 had already done the work to migrate to MUI v5. Cherry-picked all those commits and can confirm the tests still pass.

For react-virtualized, I looked at its newer alternative react-window (both of which were actually written by my current Replay teammate Brian Vaughn), and saw that he'd written a replacement package of react-window-infinite-loader for the infinite loading setup.

I just got the <TransactionInfiniteList> component ported over to use that and tests pass, so I wanted to give you a heads-up in case you wanted to cherry-pick those changes over:

@MikeMcC399
Copy link
Contributor

@markerikson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants