made changes to the conifg #1586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
@codewithsupra Thanks for the contribution! Could you please sign our CLA? |
MikeMcC399
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Unfortunately these changes are incomplete.
CI fails attempting to run yarn build:ci
$ yarn build:ci
yarn run v1.22.22
$ yarn predev:cognito:ci
$ yarn copy:mock:awsexports && yarn copy:mock:awsexportses5
$ ncp scripts/mock-aws-exports.js src/aws-exports.js
$ ncp scripts/mock-aws-exports-es5.js aws-exports-es5.js
$ cross-env CYPRESS_COVERAGE=true vite build
vite v4.5.5 building for production...
✓ 2 modules transformed.
✓ built in 209ms
[vite-plugin-eslint] Could not find config file.
Attempting to using yarn eslint fails:
$ yarn eslint .
yarn run v1.22.22
Oops! Something went wrong! :(
ESLint: 9.13.0
ESLint couldn't find an eslint.config.(js|mjs|cjs) file.
From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:
https://eslint.org/docs/latest/use/configure/migration-guide
If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
This PR is related to issues
|
See also ESLint v9 documentation Configuration Migration Guide |
|
Would you like to give some feedback on whether you can work to make this PR successful or whether it should be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the outdated eslint-config-react-app with an appropriate configuration that works with Vite and TypeScript.
Installed and configured @typescript-eslint/parser and @typescript-eslint/eslint-plugin to ensure proper linting support for TypeScript.
Integrated Prettier and updated ESLint rules to avoid conflicts between Prettier and ESLint.
Encountered some TypeScript-related linting issues, which will need further refinement, but core functionality is working.
Project now runs with ts-node for backend TypeScript files and uses nodemon to automatically reload on changes.
Addressed some linting errors but remaining warnings and errors will be resolved in future updates.