-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cumulative Update from Aldros-Alpha #306
Open
aldros-ffxi
wants to merge
5
commits into
alpha
Choose a base branch
from
aldros-alpha
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+133
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrite
requested changes
Dec 21, 2024
2a17700
to
f4c6a7e
Compare
edab99d
to
46d0fb3
Compare
4a37d19
to
5e95534
Compare
For Magic Burster, we assign `spell` on L76 as the res.spell, we then attempt to reference it on L79 as the spell class to get .name rather than .en. This results in a nil spell.
This updates shooter to be significantly faster by eliminating the forced delay. This removes the forced delay. The actual delay for shooting is a two-stage delay similar to JAs. The first forced delay is the shooting animation. That can be immediately followed by another ranged attack. However, following with another ability like a WS requires a separate 1.0s delay. This patch doesn't implement that, but significantly speeds up shooting in all cases. Weaponskills do luckily retry, so the overall change is minimal. In an ideal case we can add on more
With this change, using AutoTargetMode to engage you can also now run in if combatmode is set to melee. This significantly enhances utility in things like Odyssey Sheol farms.
13851a1
to
c5b3732
Compare
This adds a conditional 1s delay after a shot if you end up with enough TP to WS. This won't solve the JA case, but we could potentially solve that by adding things to check for in this conditional block action. This can likely be gotten from settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four PRs.
First PR adds one condition:
PartyHasMainJobCondition: IsSatisfied when the party contains a a member with main job X, Y, or Z, based on multi-picker
Second PR adds a fix for Magic Burster role:
We actually have a nil value reference on L79, since that uses the res object rather than the Spell object. This resolves that.
Third PR significantly speeds up ranged attacking.
Fourth PR updates CombatMode to work better in conjunction with AutoTargetMode