Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative Update from Aldros-Alpha #306

Open
wants to merge 5 commits into
base: alpha
Choose a base branch
from
Open

Conversation

aldros-ffxi
Copy link
Contributor

@aldros-ffxi aldros-ffxi commented Dec 21, 2024

Four PRs.

First PR adds one condition:
PartyHasMainJobCondition: IsSatisfied when the party contains a a member with main job X, Y, or Z, based on multi-picker

Second PR adds a fix for Magic Burster role:
We actually have a nil value reference on L79, since that uses the res object rather than the Spell object. This resolves that.

Third PR significantly speeds up ranged attacking.

Fourth PR updates CombatMode to work better in conjunction with AutoTargetMode

@aldros-ffxi aldros-ffxi force-pushed the aldros-alpha branch 2 times, most recently from 2a17700 to f4c6a7e Compare December 27, 2024 22:34
@aldros-ffxi aldros-ffxi requested a review from cyrite January 2, 2025 23:23
@aldros-ffxi aldros-ffxi force-pushed the aldros-alpha branch 3 times, most recently from 4a37d19 to 5e95534 Compare January 7, 2025 02:07
@aldros-ffxi aldros-ffxi changed the title Add PartyHasMainJob condition, OrCondition, and modify MagicBurster role to check for BLM in party Cumulative Update from Aldros-Alpha Jan 7, 2025
For Magic Burster, we assign `spell` on L76 as the res.spell,
we then attempt to reference it on L79 as the spell class to
get .name rather than .en. This results in a nil spell.
This updates shooter to be significantly faster by eliminating
the forced delay. This removes the forced delay. The actual
delay for shooting is a two-stage delay similar to JAs. The
first forced delay is the shooting animation. That can be
immediately followed by another ranged attack. However, following
with another ability like a WS requires a separate 1.0s delay.

This patch doesn't implement that, but significantly speeds up
shooting in all cases. Weaponskills do luckily retry, so the
overall change is minimal. In an ideal case we can add on more
With this change, using AutoTargetMode to engage you can also
now run in if combatmode is set to melee. This significantly
enhances utility in things like Odyssey Sheol farms.
This adds a conditional 1s delay after a shot if you end up
with enough TP to WS. This won't solve the JA case, but we could
potentially solve that by adding things to check for in this
conditional block action. This can likely be gotten from settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants