Skip to content

Commit e71ee62

Browse files
committed
fix iteration
1 parent 6ec5f0a commit e71ee62

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

iohub/reader.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,23 +45,30 @@ def _check_single_page_tiff(src: Path):
4545
if src.is_file():
4646
src = src.parent
4747
files = src.glob("*.tif")
48-
if len(files) == 0:
48+
try:
49+
next(files)
50+
except StopIteration:
4951
sub_dirs = _get_sub_dirs(src)
5052
if sub_dirs:
5153
files = (src / sub_dirs[0]).glob("*.tif")
52-
if len(files) > 0:
54+
try:
5355
with tiff.TiffFile(next(files)) as tf:
5456
if (
5557
len(tf.pages) == 1
5658
): # and tf.pages[0].is_multipage is False:
5759
return True
60+
except StopIteration:
61+
pass
5862
return False
5963

6064

6165
def _check_multipage_tiff(src: Path):
6266
if src.is_file():
6367
src = src.parent
64-
file = next(src.glob("*.tif"))
68+
try:
69+
file = next(src.glob("*.tif"))
70+
except StopIteration:
71+
return False
6572
with tiff.TiffFile(file) as tf:
6673
if len(tf.pages) > 1:
6774
return True

tests/test_reader.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import pytest
22

3+
from iohub._deprecated.singlepagetiff import MicromanagerSequenceReader
34
from iohub.mmstack import MMStack
45
from iohub.ndtiff import NDTiffDataset
56
from iohub.reader import read_images
6-
77
from tests.conftest import (
88
mm2gamma_ome_tiffs,
9+
mm2gamma_singlepage_tiffs,
910
mm1422_ome_tiffs,
1011
ndtiff_v2_datasets,
1112
ndtiff_v3_labeled_positions,
@@ -29,3 +30,9 @@ def test_detect_ome_tiff(data_path):
2930
def test_detect_ndtiff(data_path):
3031
reader = read_images(data_path)
3132
assert isinstance(reader, NDTiffDataset)
33+
34+
35+
@pytest.mark.parametrize("data_path", mm2gamma_singlepage_tiffs)
36+
def test_detect_single_page_tiff(data_path):
37+
reader = read_images(data_path)
38+
assert isinstance(reader, MicromanagerSequenceReader)

0 commit comments

Comments
 (0)