Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-text string truncated at apostrophe #11

Open
CaverBruce opened this issue Jul 27, 2022 · 2 comments
Open

-text string truncated at apostrophe #11

CaverBruce opened this issue Jul 27, 2022 · 2 comments

Comments

@CaverBruce
Copy link

Original th2 string
point -850.0 12038.0 remark -text "What's going on here?" -align tr -scale xs

Resultant th2 string
point -850 12038 remark -text What -scale xs -align tr

String is truncated and quotes removed.

@daem-on
Copy link
Owner

daem-on commented Nov 27, 2022

@CaverBruce
Hi! I know these issues are old, and I haven't added any new features since the semester started, but I was hoping you could check that these resolved along with #9 and #7 because I fixed them a few months ago and the issues are still open. (Only the beta version has these changes)

Before the end of the year I'll hopefully have some time to make a stable release with these fixes and maybe declare whterion ready for use (add it to the therion wiki, etc.). Or at least get some more people to test it. But right now I'm still busy so no new features unless someone opens an issue.

@CaverBruce
Copy link
Author

CaverBruce commented Nov 30, 2022

Refer to #12 for an overview of this round of checking.
I don't have a point remark with an apostrophe in my current sample file, but I do have point label examples. Most/many are good, but there are some that are not.
Original th2
point 5069.5 8529.5 label -orientation 242.7 -text "hydromagnesite" -align tr -scale xs
Resultant WT th2 string
point 5069.5 8529.5 label -text "hydromagnesite" -scale xs -orientation 242.7 -align tr
That one is good

Original th2
point 5779.0 8775.0 label -text "squeeze over<br>formation" -scale xs
Resultant WT th2 string
point 5779 8775 label -text ""squeeze over<br>formation"" -scale xs

daem-on added a commit that referenced this issue Dec 27, 2022
Change `trimEnclosing` implementation, fix `-scale` to fit specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants