We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's say take a look naming style for web server service: https://github.com/dagster-io/dagster/blob/master/helm/dagster/templates/helpers/_service-webserver.tpl#L7, or flower service: https://github.com/dagster-io/dagster/blob/master/helm/dagster/templates/service-flower.yaml#L5. They are in respect with naming convention, we can easily recognize the kind of service, while user code deployments using only deployment name: https://github.com/dagster-io/dagster/blob/master/helm/dagster/charts/dagster-user-deployments/templates/service-user.yaml#L5.
At least mimic naming from user code deployments: https://github.com/dagster-io/dagster/blob/master/helm/dagster/charts/dagster-user-deployments/templates/deployment-user.yaml#L6, at maximum introduce new template.
No response
1.8.0
Dagster Helm chart
Found at 1.8.0, currently in master branch.
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
The text was updated successfully, but these errors were encountered:
Introducing a new name might be breaking for a use case i have
Sorry, something went wrong.
No branches or pull requests
What's the issue?
Let's say take a look naming style for web server service: https://github.com/dagster-io/dagster/blob/master/helm/dagster/templates/helpers/_service-webserver.tpl#L7, or flower service: https://github.com/dagster-io/dagster/blob/master/helm/dagster/templates/service-flower.yaml#L5.
They are in respect with naming convention, we can easily recognize the kind of service, while user code deployments using only deployment name: https://github.com/dagster-io/dagster/blob/master/helm/dagster/charts/dagster-user-deployments/templates/service-user.yaml#L5.
What did you expect to happen?
At least mimic naming from user code deployments: https://github.com/dagster-io/dagster/blob/master/helm/dagster/charts/dagster-user-deployments/templates/deployment-user.yaml#L6, at maximum introduce new template.
How to reproduce?
No response
Dagster version
1.8.0
Deployment type
Dagster Helm chart
Deployment details
No response
Additional information
Found at 1.8.0, currently in master branch.
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
The text was updated successfully, but these errors were encountered: