Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: inconvinient dagster user deployment services naming #27242

Open
paralyzah opened this issue Jan 21, 2025 · 1 comment
Open

helm: inconvinient dagster user deployment services naming #27242

paralyzah opened this issue Jan 21, 2025 · 1 comment
Labels
deployment: k8s Related to deploying Dagster to Kubernetes type: bug Something isn't working

Comments

@paralyzah
Copy link

What's the issue?

Let's say take a look naming style for web server service: https://github.com/dagster-io/dagster/blob/master/helm/dagster/templates/helpers/_service-webserver.tpl#L7, or flower service: https://github.com/dagster-io/dagster/blob/master/helm/dagster/templates/service-flower.yaml#L5.
They are in respect with naming convention, we can easily recognize the kind of service, while user code deployments using only deployment name: https://github.com/dagster-io/dagster/blob/master/helm/dagster/charts/dagster-user-deployments/templates/service-user.yaml#L5.

What did you expect to happen?

At least mimic naming from user code deployments: https://github.com/dagster-io/dagster/blob/master/helm/dagster/charts/dagster-user-deployments/templates/deployment-user.yaml#L6, at maximum introduce new template.

How to reproduce?

No response

Dagster version

1.8.0

Deployment type

Dagster Helm chart

Deployment details

No response

Additional information

Found at 1.8.0, currently in master branch.

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@paralyzah paralyzah added the type: bug Something isn't working label Jan 21, 2025
@garethbrickman garethbrickman added the deployment: k8s Related to deploying Dagster to Kubernetes label Jan 21, 2025
@ion-elgreco
Copy link
Contributor

Introducing a new name might be breaking for a use case i have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment: k8s Related to deploying Dagster to Kubernetes type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants