-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Adjustments SVG Image Enlargement Issue #117
Comments
* fixes #117 restrict svg image size to 200/200 to allow for zooming of OS/Reading Systems * updated Date Published * reduced svg image size to 150x150 and combined Test 610 and 710 --------- Co-authored-by: Marisa DeMeglio <marisa.demeglio@gmail.com>
It looks like the test as implemented in v 2.0 book is not working in practice. Changing the font size does not alter the size of the new image. In the previous version of the test, the gray circle would usually change size. The SVG image is included with: However, this rises the question as to whether this test is conceptually sound. Should changing the text size also alter the size of an image? The accessibility provision valued by users is that they can zoom in, perhaps to the extent that it is larger that the screen size, and they can pan around the magnified image. This is possible in some apps (Apple Books, Thorium Reader) but would be considered an Advanced feature. |
I wonder if the image if enlarged in proportion to the text might lead to unexpected behavior. A large image to begin with might become too large for the viewport resulting for the need to pan around to see the whole image. I think that we should be testing for the enlargement of a SVG, and as an advanced feature of enlarging other image types. |
Would we want 2 images one PNG like we had and the new SVG image, but with improved CSS size that Lars is investigating? |
In an advanced book we can be a little creative, with SVG, PNG with transparent background, etc. But we do seem to be gravitating towards removing the image test from the Fundamental Visual Adjustments title, until we reach a clear position on the test and the functionality is supported in multiple reading systems. |
I believe that on October 8 we decided the following: |
This is correct and the information was sent to the list./George
From: Richard Orme ***@***.***>
Sent: Saturday, October 26, 2024 9:32 AM
To: daisy/epub-accessibility-tests ***@***.***>
Cc: George ***@***.***>; Comment ***@***.***>
Subject: Re: [daisy/epub-accessibility-tests] Visual Adjustments SVG Image Enlargement Issue (Issue #117)
I believe that on October 8 we decided the following:
Pass: the SVG is displayed correctly and we will add a comment stating this, and indicating whether the image can be zoomed.
Fail: the SVG is not displayed correctly or at all.
If this is correct then I will go through my results that I completed with the latest test book and update accordingly.
—
Reply to this email directly, view it on GitHub <#117 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABW4OSHTR7ORHNO6FA55MFTZ5OYWXAVCNFSM6AAAAABDTNGXISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZGYZDENZZG4> .
You are receiving this because you commented.Message ID: ***@***.***>
|
I just noticed that when I switched from using the circle.svg to the Flower-Frame.svg since that SVG image is so big, the test to try to increase the size fails because it is getting resized automatically down to size of the screen.
We need to limit the size to 200 / 200 in order to allow the OS/Reading system to increase its size in order to satisfy the test.
The text was updated successfully, but these errors were encountered: