Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Adjustments SVG Image Enlargement Issue #117

Open
clapierre opened this issue Feb 21, 2024 · 6 comments
Open

Visual Adjustments SVG Image Enlargement Issue #117

clapierre opened this issue Feb 21, 2024 · 6 comments

Comments

@clapierre
Copy link
Collaborator

I just noticed that when I switched from using the circle.svg to the Flower-Frame.svg since that SVG image is so big, the test to try to increase the size fails because it is getting resized automatically down to size of the screen.

We need to limit the size to 200 / 200 in order to allow the OS/Reading system to increase its size in order to satisfy the test.

clapierre added a commit to clapierre/epub-accessibility-tests that referenced this issue Feb 21, 2024
restrict svg image size to 200/200 to allow for zooming of OS/Reading Systems
marisademeglio added a commit that referenced this issue Apr 1, 2024
* fixes #117

restrict svg image size to 200/200 to allow for zooming of OS/Reading Systems

* updated Date Published

* reduced svg image size to 150x150 and combined Test 610 and 710

---------

Co-authored-by: Marisa DeMeglio <marisa.demeglio@gmail.com>
@ways2read
Copy link
Member

It looks like the test as implemented in v 2.0 book is not working in practice.

Changing the font size does not alter the size of the new image. In the previous version of the test, the gray circle would usually change size.

The SVG image is included with:
<img src="../images/Flower-Frame.svg" alt="illustration: a black and white detailed symmetrical flower" width="150" height="150"/>
and it is rendered in most cases to the maximum width of the reading view.

However, this rises the question as to whether this test is conceptually sound. Should changing the text size also alter the size of an image?

The accessibility provision valued by users is that they can zoom in, perhaps to the extent that it is larger that the screen size, and they can pan around the magnified image. This is possible in some apps (Apple Books, Thorium Reader) but would be considered an Advanced feature.

@ways2read ways2read reopened this Jul 3, 2024
@GeorgeKerscher
Copy link
Collaborator

I wonder if the image if enlarged in proportion to the text might lead to unexpected behavior. A large image to begin with might become too large for the viewport resulting for the need to pan around to see the whole image.

I think that we should be testing for the enlargement of a SVG, and as an advanced feature of enlarging other image types.

@clapierre
Copy link
Collaborator Author

Would we want 2 images one PNG like we had and the new SVG image, but with improved CSS size that Lars is investigating?

@ways2read
Copy link
Member

In an advanced book we can be a little creative, with SVG, PNG with transparent background, etc. But we do seem to be gravitating towards removing the image test from the Fundamental Visual Adjustments title, until we reach a clear position on the test and the functionality is supported in multiple reading systems.

@ways2read
Copy link
Member

I believe that on October 8 we decided the following:
Pass: the SVG is displayed correctly and we will add a comment stating this, and indicating whether the image can be zoomed.
Fail: the SVG is not displayed correctly or at all.
If this is correct then I will go through my results that I completed with the latest test book and update accordingly.

@GeorgeKerscher
Copy link
Collaborator

GeorgeKerscher commented Oct 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants