Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use websockets for push notifications #125

Open
bertfrees opened this issue Oct 30, 2017 · 3 comments
Open

Use websockets for push notifications #125

bertfrees opened this issue Oct 30, 2017 · 3 comments
Labels

Comments

@bertfrees
Copy link
Member

bertfrees commented Oct 30, 2017

Not sure if this idea was ever explored?

@bertfrees bertfrees added the idea label Oct 30, 2017
@josteinaj
Copy link
Member

I think @marisademeglio had a look at it like 5 years ago or so? There's probably better libraries for it now.

@marisademeglio
Copy link
Member

@josteinaj i thought you were the one who looked at it 😂 or was that on the web UI side? like you said, it's been a few years so there's probably something better now.

@josteinaj
Copy link
Member

Oh, hmm. Well I've never really touched the engine code so maybe you had a look at websocket libraries for the engine and I had a look at websocket libraries for the Web UI. In any case, I think the reason we didn't do it was a combination of there not being any really good libraries to do it, and that it wasn't really worth the effort at the time. Pulling for updates once every second is usually fine. There was also the callback mechanism that was implemented as a way to push messages to clients, but I don't remember if that's still supported in the engine.

Websocket support would be nice. If someone has time to look into it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants