Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrape all goos/goarch pair for stdlib #208

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Zxilly
Copy link

@Zxilly Zxilly commented May 30, 2024

Closes: #209

Now syscall/js can be recognized correctly.

@Zxilly
Copy link
Author

Zxilly commented Sep 29, 2024

@daixiang0 hello, any updates?

@Zxilly
Copy link
Author

Zxilly commented Nov 8, 2024

The patches you suggested are great, I'll apply those when I touch my computer. But it seems that the author hasn't responded for a long time and I don't know if he still concerns himself with this project.

@daixiang0
Copy link
Owner

@Zxilly thanks for care, could you update then we can make it land.

@Zxilly
Copy link
Author

Zxilly commented Nov 11, 2024

Done

@Zxilly Zxilly force-pushed the master branch 2 times, most recently from be58ff5 to 4889c14 Compare November 11, 2024 14:44
Copy link
Owner

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0
Copy link
Owner

@Zxilly Please fix lint issue.

Zxilly and others added 6 commits November 15, 2024 18:22
Signed-off-by: Zxilly <zxilly@outlook.com>
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New std lib unique,iter in go1.23 can not be recognized
3 participants