chore: update to support latest rc of turbo-ios #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unRARed
commented
Aug 23, 2022
Comment on lines
+329
to
+332
| // added to turbo-ios in 7.0.0-rc.6 | ||
| func sessionWebViewProcessDidTerminate(_ session: Session) { | ||
| // TODO | ||
| } |
There was a problem hiding this comment.
this is the meaningful piece per hotwired/turbo-ios@7.0.0-rc.5...7.0.0-rc.6#diff-b8eedf003187f841896b81cea7ce824a547fb8f3cc3ad74717f09e3bdbadebb9R14
There was a problem hiding this comment.
@dalezak This is useful, I had to do the same.
func startApp() {
// app setup
self.navigationController?.setNavigationBarHidden(true, animated: false)
self.navigationController?.view.backgroundColor = UIColor(hexRGB: "#121212")
loadNavBar()
loadTabBar()
loadTabs()
loadHome()
}
override func viewDidLoad() {
super.viewDidLoad()
startApp()
}
func sessionWebViewProcessDidTerminate(_ session: Session) {
self.navigationController?.popViewController(animated: false)
self.navigationController?.viewControllers = []
self.tabBar = makeTabBar()
self.session = makeSession()
self.modalSession = makeSession()
self.settings = loadSettings()
self.processPool = WKProcessPool()
startApp()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7
Could be more to this, but this allowed the latest 7.0.0-rc.7 package to build on my system.