Signing certificates based on CSR

[kimmokantojarvi]

Hi,
I like the package and therefore would like to propose some small enhancements for signing the certificates.
Basically functions in CreateCertificates.cs always create a new key pair instead of using existing keys from a CSR and therefore would like to propose adding possibility to sign certificates based on CSRs.
Instead of creating CertificateRequest inside the function allow bringing it as a parameter to the functions.
Functions affected:

• NewECDsaSelfSignedCertificate
• NewRsaSelfSignedCertificate
• NewRsaChainedCertificate
• NewECDsaChainedCertificate
  Best regards,
  Kimmo

[kimmokantojarvi]

Just added PR for this one if it helps.

[damienbod]

@kimmokantojarvi thanks! merged

I'll release with version 1.0.5, probably at the weekend

[damienbod]

@kimmokantojarvi just wondering about docs here, maybe a simple example in the repo would be cool showing this feature.

Would you be interested?

[kimmokantojarvi]

Sure, I can add maybe early next week. Where would you like to have those examples?

[damienbod]

@kimmokantojarvi Thanks! In this repo would be cool.

Examples using:

https://github.com/damienbod/AspNetCoreCertificates/tree/master/examplesUsingCertificateAuthentication

(I'll rename this to /examplesUsingCertificates)

Or creating:

https://github.com/damienbod/AspNetCoreCertificates/tree/master/src

Greetings Damien