-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement another scoring function (qCIPA) #18
Comments
Am I right that in this case, II, IN and NN are just the numbers of such residue pairs found at positions a and a', and EE, EK, KK the same, but for positions g and e'(in the next heptad, so position i in chain 1, and i+5 in chain 2)? Why do they even mention that they allow L at position d when they don't use it later (except for helical propensity)? |
I implemented it, scores for #16 look OK, but scores for PNIC do not (the set does not seem to be orthogonal). Is this reasonable? |
@dancsi The pairs are counted a-a' and e-g' and g-e'. And the charged interactions are e-g' and g-e' So assuming that f is the first register (and using 0-indexing), the a-a' pairs (chain 1, chain 2) would be So in short I think you forgot the other half of the electrostatic interactions:) |
I think I have implemented the thing correctly, since I am adding the interactions between both ( |
Yup, I agree, it's fine. Do you have an image for the PNIC set? |
I am making them. |
Nope that can't be right, something is wrong with this qCIPA (not necessarily with your implementation, might also be a mistake in the paper). |
Yep, it seems strange to me as well. Our coefficients for bCIPA are slightly different, as somebody converted its output to degrees Celsius, and the b coefficient is different as well. |
Can you try just
fastscore.exe ..\data\PNIC.fasta --score-func=qcipa --orientation=P
--max-heptad-displacement=0
This still looks off, although as you have correctly observed, the range is
OK:)
…On 21 January 2018 at 21:17, Daniel Siladji ***@***.***> wrote:
If I run fastscore.exe ..\data\PNIC.fasta --score-func=qcipa
--orientation=both --max-heptad-displacement=2 --truncate=0, at least the
range is OK, but it still does not seem orthogonal enough:
[image: qcipa]
<https://user-images.githubusercontent.com/405156/35198530-7f56da44-fef0-11e7-843d-5e15accbaf7f.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/dancsi/DiplomaThesis/issues/18#issuecomment-359277232>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABN1sDeGl3Atawp6By8QJZZ4lmYuY7Gks5tM5tlgaJpZM4RB0Sm>
.
|
Can you perhaps rewrite qcipa with the same machinery that BCIPA is using?
(Basically just counting the interactions and looking up values in a
dictionary? I saw you wanted to make it as fast as possible, but at this
point reliable and easy to implement new terms is probably more important:)
…On 21 January 2018 at 21:39, Daniel Siladji ***@***.***> wrote:
Garbage :(
[image: qcipa]
<https://user-images.githubusercontent.com/405156/35198733-9077a896-fef3-11e7-882c-0310eccc9622.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/dancsi/DiplomaThesis/issues/18#issuecomment-359278936>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABN1surqhT7W2MvMW2z4GWZvQZMJ4pfks5tM6CFgaJpZM4RB0Sm>
.
|
(QCIPA is basically a simplified BCIPA)
On 21 January 2018 at 22:04, Ajasja Ljubetič <ajasja.ljubetic@gmail.com>
wrote:
… Can you perhaps rewrite qcipa with the same machinery that BCIPA is using?
(Basically just counting the interactions and looking up values in a
dictionary? I saw you wanted to make it as fast as possible, but at this
point reliable and easy to implement new terms is probably more important:)
On 21 January 2018 at 21:39, Daniel Siladji ***@***.***>
wrote:
> Garbage :(
> [image: qcipa]
> <https://user-images.githubusercontent.com/405156/35198733-9077a896-fef3-11e7-882c-0310eccc9622.png>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/dancsi/DiplomaThesis/issues/18#issuecomment-359278936>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABN1surqhT7W2MvMW2z4GWZvQZMJ4pfks5tM6CFgaJpZM4RB0Sm>
> .
>
|
Sure, I can certainly try. |
I pushed those changes to a new branch (commit 5de1a8d), but the results are still the same: |
What if we asked the qCIPA people directly for their code? In the supplementary material, they say that the code is freely available upon request. |
Sure, I'll write them.
PS: I think you can merge this into the master?
Best,
Ajasja
…On 22 January 2018 at 10:41, Daniel Siladji ***@***.***> wrote:
What if we asked the qCIPA people directly for their code? In the
supplementary material, they say that the code is freely available upon
request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/dancsi/DiplomaThesis/issues/18#issuecomment-359371265>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABN1ptRBU82v6KSxyZJ_8c1EwJVocXAks5tNFfJgaJpZM4RB0Sm>
.
|
Great! I have factored out the common parts, and merged the changes into master. |
The scoring function is given in
Crooks Mason Biochemistry -2017- Computational Prediction and Design for Creating Iteratively Larger Heterospecific Coiled Coil Sets.pdf
It's very similar to bCIPA, so this should be relatively easy.
The text was updated successfully, but these errors were encountered: