Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement another scoring function (qCIPA) #18

Open
ajasja opened this issue Dec 14, 2017 · 20 comments
Open

Implement another scoring function (qCIPA) #18

ajasja opened this issue Dec 14, 2017 · 20 comments
Milestone

Comments

@ajasja
Copy link
Collaborator

ajasja commented Dec 14, 2017

The scoring function is given in
image

Crooks Mason Biochemistry -2017- Computational Prediction and Design for Creating Iteratively Larger Heterospecific Coiled Coil Sets.pdf

It's very similar to bCIPA, so this should be relatively easy.

@ajasja ajasja added this to the v3 milestone Dec 14, 2017
@dancsi
Copy link
Owner

dancsi commented Dec 23, 2017

Am I right that in this case, II, IN and NN are just the numbers of such residue pairs found at positions a and a', and EE, EK, KK the same, but for positions g and e'(in the next heptad, so position i in chain 1, and i+5 in chain 2)? Why do they even mention that they allow L at position d when they don't use it later (except for helical propensity)?

dancsi added a commit that referenced this issue Dec 23, 2017
@dancsi
Copy link
Owner

dancsi commented Dec 23, 2017

I implemented it, scores for #16 look OK, but scores for PNIC do not (the set does not seem to be orthogonal). Is this reasonable?

@ajasja
Copy link
Collaborator Author

ajasja commented Dec 23, 2017

@dancsi The pairs are counted a-a' and e-g' and g-e'.
So these are the nonpolar ones (a-a' and d-d'). The d sites are all L in their case, so for the scoring function it does not matter what the value of the d-d term is.
image

And the charged interactions are e-g' and g-e'
image

So assuming that f is the first register (and using 0-indexing), the a-a' pairs (chain 1, chain 2) would be
2-2, 9-9, etc...
the g-e' would be 1-6, 8-14 etc.. and the e-g' 6-1, 14-8 etc...

So in short I think you forgot the other half of the electrostatic interactions:)
All the other pairs are ignored.
@andy-brodnik this is also relevant to predicting a better scoring function:)

@dancsi
Copy link
Owner

dancsi commented Dec 23, 2017

I think I have implemented the thing correctly, since I am adding the interactions between both (chain1[i] and chain2[i+5]) and (chain2[i] and chain1[i+5]) for all i's that correspond to g positions

@ajasja
Copy link
Collaborator Author

ajasja commented Dec 23, 2017

Yup, I agree, it's fine. Do you have an image for the PNIC set?

@dancsi
Copy link
Owner

dancsi commented Dec 23, 2017

I am making them.

@dancsi
Copy link
Owner

dancsi commented Dec 23, 2017

Truncated:
pnic-qcipa-truncated
Not truncated:
pnic-qcipa

@ajasja
Copy link
Collaborator Author

ajasja commented Dec 23, 2017

Nope that can't be right, something is wrong with this qCIPA (not necessarily with your implementation, might also be a mistake in the paper).

@dancsi
Copy link
Owner

dancsi commented Dec 23, 2017

Yep, it seems strange to me as well. Our coefficients for bCIPA are slightly different, as somebody converted its output to degrees Celsius, and the b coefficient is different as well.

@dancsi
Copy link
Owner

dancsi commented Jan 21, 2018

Have we found out something? I have corrected an uninitialized variable bug in qCIPA, but the results still look off. Here is the new graph:
qcipa

@dancsi
Copy link
Owner

dancsi commented Jan 21, 2018

If I run fastscore.exe ..\data\PNIC.fasta --score-func=qcipa --orientation=both --max-heptad-displacement=2 --truncate=0, at least the range is OK, but it still does not seem orthogonal enough:
qcipa

@ajasja
Copy link
Collaborator Author

ajasja commented Jan 21, 2018 via email

@dancsi
Copy link
Owner

dancsi commented Jan 21, 2018

Garbage :(
qcipa
Keep in mind that the temperature scale is reversed, so P1, P1 melts at -500C xD

@ajasja
Copy link
Collaborator Author

ajasja commented Jan 21, 2018 via email

@ajasja
Copy link
Collaborator Author

ajasja commented Jan 21, 2018 via email

@dancsi
Copy link
Owner

dancsi commented Jan 21, 2018

Sure, I can certainly try.

@dancsi
Copy link
Owner

dancsi commented Jan 21, 2018

I pushed those changes to a new branch (commit 5de1a8d), but the results are still the same:
qcipa

@dancsi
Copy link
Owner

dancsi commented Jan 22, 2018

What if we asked the qCIPA people directly for their code? In the supplementary material, they say that the code is freely available upon request.

@ajasja
Copy link
Collaborator Author

ajasja commented Jan 22, 2018 via email

@dancsi
Copy link
Owner

dancsi commented Jan 22, 2018

Great! I have factored out the common parts, and merged the changes into master.

dancsi added a commit that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants