Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logout support #66

Open
franzwilhelm opened this issue Mar 28, 2022 · 8 comments
Open

Add logout support #66

franzwilhelm opened this issue Mar 28, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@franzwilhelm
Copy link

Describe the bug

Currently, the authenticator.logout method is not logging the user out in auth0.

See this issue for further details:

sergiodxa/remix-auth-oauth2#15

Current usage

Right now I have to manually do the auth0 logout by doing a double redirect in my logout function:

export const loader: LoaderFunction = async ({ request }) => {
  return authenticator.logout(request, {
    redirectTo: `https://${appConfig.auth0.issuerBaseUrl}/v2/logout?client_id=${appConfig.auth0.clientId}&returnTo=${appConfig.auth0.baseUrl}/auth/login`,
  });
};

Expected usage

export const loader: LoaderFunction = async ({ request }) => {
  return authenticator.logout(request, {
    redirectTo: `/auth/login`,
  });
};

Your Example Website or App

https://test.com

Steps to Reproduce the Bug or Issue

  1. Use authenticator.logout
  2. Try to log in again
  3. The user is automatically logged in as the auth0 logout endpoint never got called

Expected behavior

Ths user should be logged out of auth0 when using authenticator.logout

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

No response

@franzwilhelm
Copy link
Author

Currently blocking on sergiodxa/remix-auth#125

@danestves danestves added enhancement New feature or request good first issue Good for newcomers labels Mar 28, 2022
@danestves danestves self-assigned this Mar 28, 2022
@EdenTurgeman
Copy link

Are there any updates regarding this issue?

@danestves
Copy link
Owner

Are there any updates regarding this issue?

Hello! At the moment my work consumes almost all my hours, as soon as I have any free time will look into this issue to work on it

@rojvv
Copy link

rojvv commented Jan 22, 2023

Updates?

@meza
Copy link

meza commented Feb 20, 2023

Seems like https://github.com/sergiodxa/remix-auth needs to add the option to use the strategy for logout first. :(

@rojvv
Copy link

rojvv commented Feb 21, 2023

@sergiodxa

@stephencweiss
Copy link

@roj1512 - looks like @sergiodxa doesn't think this is related to remix-auth: sergiodxa/remix-auth-oauth2#15 (comment)

@rojvv
Copy link

rojvv commented Feb 21, 2023

@danestves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants