Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still draws the line if there are no replies #7

Open
westlinkin opened this issue Mar 29, 2022 · 6 comments
Open

Still draws the line if there are no replies #7

westlinkin opened this issue Mar 29, 2022 · 6 comments

Comments

@westlinkin
Copy link

Great library!

But if the root comment has no replies, the lib will draw the line to the next root comment. But if there are replies, the line end with the last reply, won't draw to the next root comment.

I think if there are no replies, it shouldn't draw the line at all.

Thanks.

@bugrevealingbme
Copy link

agree

@immi420
Copy link

immi420 commented Jul 30, 2022

Did you find any solution to this issue?

@westlinkin
Copy link
Author

Did you find any solution to this issue?

I updated the root_comment_widget myself, passed in a boolean value called hasReplies, if it is true, do not draw anything inside paint function of RootPainter.

This project seems out of maintaining, so I didn't bother submitting the PR.

@immi420
Copy link

immi420 commented Aug 9, 2022

i did a similar thing and replaced the line color to Transparent when there's no replies and that worked

@raduungurean
Copy link

        treeThemeData: TreeThemeData(
          lineColor: Colors.green[500]!,
          lineWidth: comment.replies!.isEmpty ? 0 : 3,
        ),

@pishguy
Copy link

pishguy commented Oct 6, 2023

@westlinkin
@raduungurean

hi, do you know how can we connect root avatars together? like with another timelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants