Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTL on Redis #69

Open
Kludex opened this issue Aug 5, 2022 · 1 comment · May be fixed by #81
Open

TTL on Redis #69

Kludex opened this issue Aug 5, 2022 · 1 comment · May be fixed by #81

Comments

@Kludex
Copy link
Contributor

Kludex commented Aug 5, 2022

Currently, there's no expire time on the keys created on Redis. I'm concerned about orphan keys during the lifetime of the application. A full clean can be performed from time to time... But I guess we can also enable a TTL parameter on those.

To be specific, image I create a namespace "potato", then I'll have the key "potato:pybreaker:state". If I decide to change the namespace, I'll have the previous key being orphan.
@danielfm
Copy link
Owner

I imagine those keys would consume very little space in a Redis server, but having a way to set a TTL wouldn't hurt.

@rodrigobraga rodrigobraga linked a pull request Jun 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TTL to Redis Storage rodrigobraga/pybreaker
2 participants
@danielfm @Kludex