Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with av version 14.* (variable_fps AttributeError) #2

Open
bjudkewitz opened this issue Jan 30, 2025 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@bjudkewitz
Copy link
Contributor

bjudkewitz commented Jan 30, 2025

Using av version 14.*, VideoReader init fails with

AttributeError: 'av.format.ContainerFormat' object has no attribute 'variable_fps'

Not a major problem as long as av < 14 (dependency lilsts were updated), but may have to be revisited in the future.

@bjudkewitz bjudkewitz added the enhancement New feature or request label Jan 30, 2025
@bjudkewitz bjudkewitz changed the title variable_fps AttributeError for av >= 14 incompatible with av version 14.* (variable_fps AttributeError) Jan 30, 2025
@bjudkewitz
Copy link
Contributor Author

PyAV-Org/PyAV#1741

@bjudkewitz
Copy link
Contributor Author

It seems like variable_fps support was dropped by the libav library. One solution is to drop this check and remove these two lines:

daio/src/daio/video.py

Lines 29 to 30 in ea2d8d4

if self.container.format.variable_fps:
warn_transcode(f'Variable frame rate video detected. Seeking will likely be unrealiable. I will warn again if I detect seek gitches')

We are separately checking for mismatches between expected and actual pts anyway, so dropping this specific check might be acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant