Skip to content

Commit 009ceca

Browse files
authored
enabled and fixed modernize-use-override clang-tidy warnings (#552)
1 parent dcc4fdd commit 009ceca

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

.clang-tidy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ Checks: >
3636
-modernize-use-equals-delete,
3737
-modernize-use-default-member-init,
3838
-modernize-use-nodiscard,
39-
-modernize-use-override,
4039
-modernize-use-trailing-return-type,
4140
-modernize-use-using,
4241
-readability-avoid-nested-conditional-operator,

simplecpp.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -358,16 +358,16 @@ class StdIStream : public simplecpp::TokenList::Stream {
358358
init();
359359
}
360360

361-
virtual int get() override {
361+
int get() override {
362362
return istr.get();
363363
}
364-
virtual int peek() override {
364+
int peek() override {
365365
return istr.peek();
366366
}
367-
virtual void unget() override {
367+
void unget() override {
368368
istr.unget();
369369
}
370-
virtual bool good() override {
370+
bool good() override {
371371
return istr.good();
372372
}
373373

@@ -386,20 +386,20 @@ class StdCharBufStream : public simplecpp::TokenList::Stream {
386386
init();
387387
}
388388

389-
virtual int get() override {
389+
int get() override {
390390
if (pos >= size)
391391
return lastStatus = EOF;
392392
return str[pos++];
393393
}
394-
virtual int peek() override {
394+
int peek() override {
395395
if (pos >= size)
396396
return lastStatus = EOF;
397397
return str[pos];
398398
}
399-
virtual void unget() override {
399+
void unget() override {
400400
--pos;
401401
}
402-
virtual bool good() override {
402+
bool good() override {
403403
return lastStatus != EOF;
404404
}
405405

@@ -429,20 +429,20 @@ class FileStream : public simplecpp::TokenList::Stream {
429429
file = nullptr;
430430
}
431431

432-
virtual int get() override {
432+
int get() override {
433433
lastStatus = lastCh = fgetc(file);
434434
return lastCh;
435435
}
436-
virtual int peek() override {
436+
int peek() override {
437437
// keep lastCh intact
438438
const int ch = fgetc(file);
439439
unget_internal(ch);
440440
return ch;
441441
}
442-
virtual void unget() override {
442+
void unget() override {
443443
unget_internal(lastCh);
444444
}
445-
virtual bool good() override {
445+
bool good() override {
446446
return lastStatus != EOF;
447447
}
448448

0 commit comments

Comments
 (0)