Skip to content

Commit 191f466

Browse files
committed
bumped to Visual Studio warning level 4
1 parent 3235a65 commit 191f466

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

CMakeLists.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,8 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
3939
set_source_files_properties(test.cpp PROPERTIES COMPILE_FLAGS -Wno-multichar)
4040
elseif (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
4141
add_compile_definitions(_CRT_SECURE_NO_WARNINGS)
42-
# TODO: bump warning level
43-
#add_compile_options(/W4) # Warning Level
44-
# TODO: enable warning
42+
add_compile_options(/W4) # Warning Level
43+
add_compile_options(/wd4244) # warning C4244: 'x': conversion from 'int' to 'char', possible loss of data
4544
add_compile_options(/wd4267) # warning C4267: '...': conversion from 'size_t' to 'unsigned int', possible loss of data
4645
elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
4746
add_compile_options(-Weverything)

0 commit comments

Comments
 (0)